public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"Maciej W. Rozycki" <macro@linux-mips.org>,
	Tom Spink <tspink@gmail.com>, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Jiri Slaby <jirislaby@gmail.com>, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [RFC] x86: merge nmi_32-64 to nmi.c
Date: Sun, 18 May 2008 14:29:14 +0400	[thread overview]
Message-ID: <20080518102914.GI6948@cvg> (raw)
In-Reply-To: <48300426.8080300@firstfloor.org>

[Andi Kleen - Sun, May 18, 2008 at 12:25:42PM +0200]
| Cyrill Gorcunov wrote:
| 
| > yes, but what to do with absence of __nmi_count on 32bit and die_nmi
| > uses different number of args? gcc follows both pathes anyway trying
| > to evaluate where I prefer it would not... I mean I've got errors
| > on compiling procedue 'cause of different number of args for die_nmi
| > used in 32bit mode. That is why I've asked Thomas if it possible to
| > add "panic" boot option for 32bit mode and make it familiar with 64bit
| > mode and merge them eventually.
| 
| Sorry just pointed out why the Kconfig idea doesn't work, nothing more.
| 
| If you want to avoid ifdefs then you have to unify the functionality
| first. Putting syntactical sugar on ifdefs doesn't make sense.
| 
| I haven't kept track of the exact state of the code, but if the per cpu
| data macros are finally as efficient as the PDA you could move the
| nmi_count to per_cpu in both for once.
| 
| -Andi
| 

ok, thanks

		- Cyrill -

  reply	other threads:[~2008-05-18 10:29 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-17 19:22 [RFC] x86: merge nmi_32-64 to nmi.c Cyrill Gorcunov
2008-05-17 20:28 ` Tom Spink
2008-05-17 20:52   ` Maciej W. Rozycki
2008-05-17 21:40     ` Thomas Gleixner
2008-05-18  7:25       ` Jeremy Fitzhardinge
2008-05-18  7:38         ` Cyrill Gorcunov
2008-05-18  8:33           ` Jeremy Fitzhardinge
2008-05-18  8:47             ` Cyrill Gorcunov
2008-05-18  9:13             ` Cyrill Gorcunov
2008-05-18  9:09         ` Thomas Gleixner
2008-05-18  9:35           ` Cyrill Gorcunov
2008-05-18 18:08         ` Adrian Bunk
2008-05-18 18:13           ` Andi Kleen
2008-05-18 18:35             ` Jeremy Fitzhardinge
2008-05-18 19:13               ` Andi Kleen
2008-05-19 14:27                 ` Cyrill Gorcunov
2008-05-18 18:33           ` Jeremy Fitzhardinge
2008-05-18 19:29             ` Adrian Bunk
2008-05-18 19:51               ` Jeremy Fitzhardinge
2008-05-18 18:38           ` Maciej W. Rozycki
2008-05-18 20:40             ` Adrian Bunk
2008-05-18 10:15       ` Andi Kleen
2008-05-18 10:20         ` Cyrill Gorcunov
2008-05-18 10:25           ` Andi Kleen
2008-05-18 10:29             ` Cyrill Gorcunov [this message]
2008-05-18 12:07               ` Tom Spink
2008-05-18 12:10                 ` Cyrill Gorcunov
2008-05-17 21:48     ` Mikael Pettersson
2008-05-17 22:34       ` Thomas Gleixner
2008-05-18  6:24         ` Cyrill Gorcunov
2008-05-18 10:04         ` Cyrill Gorcunov
2008-05-18 10:09         ` Cyrill Gorcunov
2008-05-19 18:07         ` Cyrill Gorcunov
2008-05-19 18:41           ` Cyrill Gorcunov
2008-05-21  7:41             ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080518102914.GI6948@cvg \
    --to=gorcunov@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    --cc=tspink@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox