From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755522AbYERKpe (ORCPT ); Sun, 18 May 2008 06:45:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752705AbYERKpW (ORCPT ); Sun, 18 May 2008 06:45:22 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:57849 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752549AbYERKpU (ORCPT ); Sun, 18 May 2008 06:45:20 -0400 From: "Rafael J. Wysocki" To: Tobias Diedrich Subject: Re: hibernate event order question Date: Sun, 18 May 2008 12:45:13 +0200 User-Agent: KMail/1.9.6 (enterprise 20070904.708012) Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ayaz Abdulla References: <20080517175046.GA9032@yamamaya.is-a-geek.org> <20080517223622.GA2668@yamamaya.is-a-geek.org> <20080517232411.GA8792@yamamaya.is-a-geek.org> In-Reply-To: <20080517232411.GA8792@yamamaya.is-a-geek.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805181245.13899.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, 18 of May 2008, Tobias Diedrich wrote: > Tobias Diedrich wrote: > > > > Shouldn't there be a 'prepare for poweroff'-callback, which gets > > > > called > > > > before the system is powered off for real? > > > > > > Yes, it should and it's called in recent kernels. > > > > For what values of 'recent'? > > I'm running 2.6.26-rc2 here. :) > > How do I hook into this callback? > > (suspend_late maybe? Going to try that one next...) > > Ok, this patch fixes the 'regression' introduced by the previous > patch (at least for me ;)): Well, what exactly do you do to hibernate the box? > Index: linux-2.6.26-rc2.forcedwol/drivers/net/forcedeth.c > =================================================================== > --- linux-2.6.26-rc2.forcedwol.orig/drivers/net/forcedeth.c 2008-05-18 01:10:18.000000000 +0200 > +++ linux-2.6.26-rc2.forcedwol/drivers/net/forcedeth.c 2008-05-18 01:11:33.000000000 +0200 > @@ -5828,8 +5828,24 @@ > out: > return rc; > } > + > +static void nv_shutdown(struct pci_dev *pdev) > +{ > + struct net_device *dev = pci_get_drvdata(pdev); > + struct fe_priv *np = netdev_priv(dev); > + u8 __iomem *base = get_hwbase(dev); > + > + if (netif_running(dev)) > + nv_close(dev); > + > + pci_enable_wake(pdev, PCI_D3hot, np->wolenabled); > + pci_enable_wake(pdev, PCI_D3cold, np->wolenabled); > + pci_disable_device(pdev); > + pci_set_power_state(pdev, PCI_D3hot); > +} > #else > #define nv_suspend NULL > +#define nv_shutdown NULL > #define nv_resume NULL > #endif /* CONFIG_PM */ > > @@ -6000,6 +6016,7 @@ > .remove = __devexit_p(nv_remove), > .suspend = nv_suspend, > .resume = nv_resume, > + .shutdown = nv_shutdown, > }; > > static int __init init_nic(void) >