public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alistair John Strachan <alistair@devzero.co.uk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Jens Axboe <jens.axboe@oracle.com>,
	xfs@oss.sgi.com, Neil Brown <neilb@suse.de>,
	Nick Piggin <npiggin@suse.de>,
	linux-kernel@vger.kernel.org, dgc@sgi.com
Subject: Re: XFS/md/blkdev warning (was Re: Linux 2.6.26-rc2)
Date: Sun, 18 May 2008 15:12:42 +0100	[thread overview]
Message-ID: <200805181512.42921.alistair@devzero.co.uk> (raw)
In-Reply-To: <20080517233908.GA15279@infradead.org>

On Sunday 18 May 2008 00:39:08 Christoph Hellwig wrote:
> On Sat, May 17, 2008 at 02:17:37PM -0700, Linus Torvalds wrote:
> > > [4294293.003500]  [<ffffffff8028106a>] __kmalloc+0x3e/0xe6
> > > [4294293.003500]  [<ffffffff803067fc>] ? xfs_iflush_int+0x272/0x2fb
> > > [4294293.003500]  [<ffffffff80320552>] kmem_alloc+0x6a/0xd1
> > > [4294293.003500]  [<ffffffff80307a9c>] xfs_iflush_cluster+0x4b/0x33f
> > > [4294293.003500]  [<ffffffff8030681e>] ? xfs_iflush_int+0x294/0x2fb
> > > [4294293.003500]  [<ffffffff80307f4b>] xfs_iflush+0x1bb/0x29d
> > > [4294293.003500]  [<ffffffff8031bc30>] xfs_inode_flush+0xb8/0xdd
> > > [4294293.003500]  [<ffffffff80328b1f>] xfs_fs_write_inode+0x30/0x4c
> >
> > And as a result, all the XFS stuff is then waiting for that lock which is
> > held by pdflush above:
>
> Btw, just that function has a missing GFP_NOFS and a too large
> allocation which were fixed by Dave Chinner but aren't in mainline
> yet.  Can you check whether it still happens with the patch below?

These patches fix the problem. Thanks Christoph.

-- 
Cheers,
Alistair.

137/1 Warrender Park Road, Edinburgh, UK.

  reply	other threads:[~2008-05-18 14:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-12 14:55 Linux 2.6.26-rc2 Linus Torvalds
2008-05-12 19:32 ` Bart Van Assche
2008-05-12 19:55   ` Linus Torvalds
2008-05-12 23:22     ` Kasper Sandberg
     [not found] ` <200805121726.15576.alistair@devzero.co.uk>
     [not found]   ` <alpine.LFD.1.10.0805120933310.3019@woody.linux-foundation.org>
     [not found]     ` <20080512164920.GE16217@kernel.dk>
2008-05-13  1:05       ` [PATCH] Remove blkdev warning triggered by using md Neil Brown
2008-05-17 18:22       ` XFS/md/blkdev warning (was Re: Linux 2.6.26-rc2) Alistair John Strachan
2008-05-17 18:37         ` Linus Torvalds
2008-05-17 18:41           ` Linus Torvalds
2008-05-17 20:09           ` Alistair John Strachan
2008-05-17 21:17             ` Linus Torvalds
2008-05-17 23:12               ` Alistair John Strachan
2008-05-17 23:39               ` Christoph Hellwig
2008-05-18 14:12                 ` Alistair John Strachan [this message]
2008-05-13  1:49 ` Oops on -rc2-git1, possibly md_raid1 or xfs related. (Was: " Kasper Sandberg
2008-05-13  1:55   ` Kasper Sandberg
2008-05-13  2:19   ` Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805181512.42921.alistair@devzero.co.uk \
    --to=alistair@devzero.co.uk \
    --cc=dgc@sgi.com \
    --cc=hch@infradead.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=npiggin@suse.de \
    --cc=torvalds@linux-foundation.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox