public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-input@vger.kernel.org, linux-parisc@vger.kernel.org
Subject: [patch 11/18] m68k: Some input drivers do not check the platform
Date: Sun, 18 May 2008 20:47:17 +0200	[thread overview]
Message-ID: <20080518185152.437771120@mail.of.borg> (raw)
In-Reply-To: 20080518184706.631023070@mail.of.borg

[-- Attachment #1: m68k-input-drivers-break-multiplatform.diff --]
[-- Type: text/plain, Size: 1777 bytes --]

From: Geert Uytterhoeven <geert@linux-m68k.org>

Some input drivers do not check whether they're actually running on the
correct platform, causing multi-platform kernels to crash if they are not.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/input/keyboard/hilkbd.c  |    4 ++++
 drivers/input/misc/hp_sdc_rtc.c  |    5 +++++
 drivers/input/serio/hp_sdc_mlc.c |    5 +++++
 3 files changed, 14 insertions(+)

--- a/drivers/input/keyboard/hilkbd.c
+++ b/drivers/input/keyboard/hilkbd.c
@@ -217,6 +217,10 @@ hil_keyb_init(void)
 		return -ENOMEM;
 
 #if defined(CONFIG_HP300)
+	if (!MACH_IS_HP300) {
+		err = -ENODEV;
+		goto err1;
+	}
 	if (!hwreg_present((void *)(HILBASE + HIL_DATA))) {
 		printk(KERN_ERR "HIL: hardware register was not found\n");
 		err = -ENODEV;
--- a/drivers/input/misc/hp_sdc_rtc.c
+++ b/drivers/input/misc/hp_sdc_rtc.c
@@ -691,6 +691,11 @@ static int __init hp_sdc_rtc_init(void)
 {
 	int ret;
 
+#ifdef __mc68000__
+	if (!MACH_IS_HP300)
+		return -ENODEV;
+#endif
+
 	init_MUTEX(&i8042tregs);
 
 	if ((ret = hp_sdc_request_timer_irq(&hp_sdc_rtc_isr)))
--- a/drivers/input/serio/hp_sdc_mlc.c
+++ b/drivers/input/serio/hp_sdc_mlc.c
@@ -306,6 +306,11 @@ static int __init hp_sdc_mlc_init(void)
 {
 	hil_mlc *mlc = &hp_sdc_mlc;
 
+#ifdef __mc68000__
+	if (!MACH_IS_HP300)
+		return -ENODEV;
+#endif
+
 	printk(KERN_INFO PREFIX "Registering the System Domain Controller's HIL MLC.\n");
 
 	hp_sdc_mlc_priv.emtestmode = 0;

-- 
Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


  parent reply	other threads:[~2008-05-18 19:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-18 18:47 [patch 00/18] Updated m68k patches for 2.6.26 Geert Uytterhoeven
2008-05-18 18:47 ` [patch 01/18] m68k: Convert access_ok() to an inline function Geert Uytterhoeven
2008-05-18 18:47 ` [patch 02/18] m68k: Kill CONFIG_FB_DAFB Geert Uytterhoeven
2008-05-18 18:47 ` [patch 03/18] m68k: FB_HP300 depends on DIO and doesnt need FB_CFB_FILLRECT Geert Uytterhoeven
2008-05-18 18:47 ` [patch 04/18] m68k: Kill CONFIG_WHIPPET_SERIAL Geert Uytterhoeven
2008-05-18 18:47 ` [patch 05/18] m68k vme_scc: avoid global namespace pollution Geert Uytterhoeven
2008-05-18 18:47 ` [patch 06/18] m68k: Make gcc aware that BUG() does not return Geert Uytterhoeven
2008-05-18 18:47 ` [patch 07/18] m68k: Correct jump if not running on HP300 Geert Uytterhoeven
2008-05-18 18:47 ` [patch 08/18] m68k: macide doesnt check for Mac Geert Uytterhoeven
2008-05-18 18:47 ` [patch 09/18] m68k: dnfb doesnt check for Apollo Geert Uytterhoeven
2008-05-18 18:47 ` [patch 10/18] m68k: Some network drivers do not check the platform Geert Uytterhoeven
2008-05-18 18:47 ` Geert Uytterhoeven [this message]
2008-05-18 18:47 ` [patch 12/18] m68k: Return -ENODEV if no device is found Geert Uytterhoeven
2008-05-18 18:47 ` [patch 13/18] m68k: Q40/Q60 floppy support is broken Geert Uytterhoeven
2008-05-18 18:47 ` [patch 14/18] m68k: export m68k_mmutype Geert Uytterhoeven
2008-05-18 18:47 ` [patch 15/18] m68k: Prefix ISA type with ISA_TYPE_ Geert Uytterhoeven
2008-05-18 18:47 ` [patch 16/18] m68k: Correctly handle multi-ISA at runtime Geert Uytterhoeven
2008-05-18 18:47 ` [patch 17/18] m68k: Update defconfigs Geert Uytterhoeven
2008-05-18 18:47 ` [patch 18/18] m68k: Add multi_defconfig Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080518185152.437771120@mail.of.borg \
    --to=geert@linux-m68k.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox