From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758176AbYEROQ2 (ORCPT ); Sun, 18 May 2008 10:16:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752481AbYEROQV (ORCPT ); Sun, 18 May 2008 10:16:21 -0400 Received: from ozlabs.org ([203.10.76.45]:54271 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752480AbYEROQU (ORCPT ); Sun, 18 May 2008 10:16:20 -0400 From: Rusty Russell To: Avi Kivity Subject: Re: [PATCH] virtio_net: free transmit skbs in a timer Date: Mon, 19 May 2008 00:16:10 +1000 User-Agent: KMail/1.9.9 Cc: Mark McLoughlin , Anthony Liguori , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org References: <1209565906-9019-1-git-send-email-markmc@redhat.com> <200805160925.18087.rusty@rustcorp.com.au> <482FCF45.1050307@qumranet.com> In-Reply-To: <482FCF45.1050307@qumranet.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805190016.10823.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 18 May 2008 16:40:05 Avi Kivity wrote: > Rusty Russell wrote: > > On Friday 16 May 2008 01:32:47 Avi Kivity wrote: > >> Mark McLoughlin wrote: > >>> I think Rusty is speaking from the POV of the guest driver - i.e. that > >>> virtio_net should never disable notifications on the xmit queue using > >>> disable_cb()? > >>> > >>> Sounds like you think agree, but that the host side should throttle the > >>> rate of xmit notifications? > >> > >> Yes. > > > > But performance is going to suck in the meantime, as currently our host > > doesn't do this. > > That's what the feature bits are for. OK. And since the current situation is that the host doesn't throttle, the feature bit should be "don't throttle, host is doing it for you", and Mark's patch should go in... Cheers, Rusty.