From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757600AbYESLTQ (ORCPT ); Mon, 19 May 2008 07:19:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755508AbYESLTG (ORCPT ); Mon, 19 May 2008 07:19:06 -0400 Received: from lazybastard.de ([212.112.238.170]:49644 "EHLO longford.logfs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755467AbYESLTF (ORCPT ); Mon, 19 May 2008 07:19:05 -0400 Date: Mon, 19 May 2008 13:18:51 +0200 From: =?utf-8?B?SsO2cm4=?= Engel To: Bryan Wu Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Mike Frysinger Subject: Re: [PATCH 1/1] mtd maps - Blackfin Async Flash Maps (try #4): Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank Message-ID: <20080519111851.GA32679@logfs.org> References: <1211193144-7731-1-git-send-email-cooloney@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1211193144-7731-1-git-send-email-cooloney@kernel.org> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 May 2008 18:32:24 +0800, Bryan Wu wrote: > > [try #4] > - drop superfluous casts > - drop SSYNC() when reading from the flash and rewrite > bfin_copy_from() to be like bfin_copy_to() so that > we dont have to handle all the aligned/unaligned cases > > [try #3] rename bf5xx-flash to bfin-async-flash > - move all kconfig board settings into board resources > - fixup casting style according to lkml feedback > - rewrite driver so that it can handle arbitrary of > instances according to the declared platform resources > > [try #2] > Remove useless SSYNC() as Will said > > [try #1] > The BF533-STAMP does this for example. > All board-specific configuration goes in your board resources file. > > Signed-off-by: Mike Frysinger > Cc: Joern Engel > Signed-off-by: Bryan Wu Looks good to me. If dwmw2 doesn't mind adding another mapping driver, this can go in. Not that I had any idea how physmap could sanely cover this driver too. Acked-By: Joern Engel Jörn -- Ninety percent of everything is crap. -- Sturgeon's Law