From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: remove used member(struct rcu_data::rcu_tasklet)
Date: Mon, 19 May 2008 05:29:19 -0700 [thread overview]
Message-ID: <20080519122919.GA7515@linux.vnet.ibm.com> (raw)
In-Reply-To: <48313277.1030105@cn.fujitsu.com>
On Mon, May 19, 2008 at 03:55:35PM +0800, Lai Jiangshan wrote:
> Since softirq works for rcu reclaimer, rcu_tasklet is unused now.
good catch!
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
>
> diff --git a/kernel/rcupreempt.c b/kernel/rcupreempt.c
> index e1cdf19..4270de6 100644
> --- a/kernel/rcupreempt.c
> +++ b/kernel/rcupreempt.c
> @@ -82,7 +82,6 @@ struct rcu_data {
> spinlock_t lock; /* Protect rcu_data fields. */
> long completed; /* Number of last completed batch. */
> int waitlistcount;
> - struct tasklet_struct rcu_tasklet;
> struct rcu_head *nextlist;
> struct rcu_head **nexttail;
> struct rcu_head *waitlist[GP_STAGES];
>
>
prev parent reply other threads:[~2008-05-19 12:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 7:55 remove used member(struct rcu_data::rcu_tasklet) Lai Jiangshan
2008-05-19 12:29 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080519122919.GA7515@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox