Re: [PATCH 18/57] iTCO: unlocked_ioctl, coding style and cleanup

Andrew Morton
2008-05-21T04:37:55Z

On Wed, 21 May 2008 14:26:15 +1000 Rusty Russell <rusty@rustcorp.com.au> wrote:

> > decent-sized smashup during the merge window. There are lessons
> > here...
>
> I've been pulling out s/down_trylock/down_nowait/ patches which effect others'
> changes. Those patches get moved to the end of my queue, and I'll revisit
> them before an actual merge with Linus.
>
> As down_trylock still works (but marked deprecated) with my patches, they're
> fine to drop. Just tell me which ones...

Well, a simple patch which does

/*
* comment goes here
*/
static inline int __must_check down_nowait(struct semaphore *sem)
{
return !down_trylock(sem);
}

and which does not deprecate down_trylock() could go into mainline
right now, (assuming that the overall concept doesn't get shot down in
review - did it get reviewed?)

Then you can start trickling stuff out to people straight away.