From: Andrew Morton <akpm@linux-foundation.org>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] signals: fix sigqueue_free() vs __exit_signal() race
Date: Mon, 19 May 2008 23:33:30 -0700 [thread overview]
Message-ID: <20080519233330.b594783a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080517151418.GA9487@tv-sign.ru>
On Sat, 17 May 2008 19:14:18 +0400 Oleg Nesterov <oleg@tv-sign.ru> wrote:
> __exit_signal() does flush_sigqueue(tsk->pending) outside of ->siglock.
> This can race with another thread doing sigqueue_free(), we can free
> the same SIGQUEUE_PREALLOC sigqueue twice or corrupt the pending->list.
>
> Note that even sys_exit_group() can trigger this race, not only
> sys_timer_delete().
>
> Move the callsite of flush_sigqueue(tsk->pending) under ->siglock.
>
> This patch doesn't touch flush_sigqueue(->shared_pending) below, it is
> called when there are no other threads which can play with signals,
> and sigqueue_free() can't be used outside of our thread group.
afacit this is the only needed-in-2.6.26 patch from these two
three-patch series, yes?
next prev parent reply other threads:[~2008-05-20 6:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-17 15:14 [PATCH 1/3] signals: fix sigqueue_free() vs __exit_signal() race Oleg Nesterov
2008-05-20 6:33 ` Andrew Morton [this message]
2008-05-20 9:17 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080519233330.b594783a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox