From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1760319AbYETGVZ@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760319AbYETGVZ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 20 May 2008 02:21:25 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754568AbYETGVR
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 20 May 2008 02:21:17 -0400
Received: from bombadil.infradead.org ([18.85.46.34]:54193 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754065AbYETGVR (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 20 May 2008 02:21:17 -0400
Date: Tue, 20 May 2008 02:20:56 -0400
From: Christoph Hellwig <hch@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jonathan Corbet <corbet@lwn.net>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@linux-foundation.org>,
       Peter Zijlstra <a.p.zijlstra@chello.nl>,
       Thomas Gleixner <tglx@linutronix.de>,
       Alan Cox <alan@lxorguk.ukuu.org.uk>,
       Alexander Viro <viro@ftp.linux.org.uk>, linux-kernel@vger.kernel.org,
       Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCH 2/3, RFC] watchdog dev BKL pushdown
Message-ID: <20080520062056.GA5292@infradead.org>
References: <13762.1211142411@vena.lwn.net> <200805200107.51659.arnd@arndb.de> <200805200111.47275.arnd@arndb.de> <200805200114.24819.arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200805200114.24819.arnd@arndb.de>
User-Agent: Mutt/1.5.17 (2007-11-01)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org
	See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 20, 2008 at 01:14:23AM +0200, Arnd Bergmann wrote:
> The Big Kernel Lock has been pushed down from chardev_open
> to misc_open, this change moves it to the individual watchdog
> driver open functions.
> 
> As before, the change was purely mechanical, most drivers
> should actually not need the BKL.

Actually I'd prefer to fix this for real.  This single open stuff aswell
as same set of ioctls are duplicated all over the watchdog drivers.  We'd
be much better off introducing a simple watchdog layer that handles this
plus proper locking and convert drivers over to it gradually.