public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Javier Herrero <jherrero@hvsistemas.es>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Bryan Wu <cooloney@kernel.org>
Subject: Re: b4aa54d951d38d7a989d6b6385494ef5ea7371d7 breaks some serial configurations
Date: Tue, 20 May 2008 09:32:17 +0100	[thread overview]
Message-ID: <20080520083217.GA10172@flint.arm.linux.org.uk> (raw)
In-Reply-To: <483286AF.2090302@hvsistemas.es>

On Tue, May 20, 2008 at 10:07:11AM +0200, Javier Herrero wrote:
> Does the problem arise due to the change of inclusion order of 
> asm/serial.h (from after 8250.h to before 8250.h) ?

Yes.  It was placed where it was because of the dependencies of
asm/serial.h on the code between the two places.

The alternative solution is to get rid of the CONFIG_* compatibility
and update those asm/serial.h which reference the old symbols.
However, that's a larger patch.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

  reply	other threads:[~2008-05-20  8:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20  7:35 b4aa54d951d38d7a989d6b6385494ef5ea7371d7 breaks some serial configurations Russell King
2008-05-20  8:07 ` Javier Herrero
2008-05-20  8:32   ` Russell King [this message]
2008-05-20 10:52     ` Javier Herrero
2008-05-20 23:13       ` Russell King
2008-05-20 23:21         ` Mike Frysinger
2008-05-21  5:45         ` Javier Herrero
2008-05-21  6:38           ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080520083217.GA10172@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cooloney@kernel.org \
    --cc=jherrero@hvsistemas.es \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox