From: Ingo Molnar <mingo@elte.hu>
To: Avi Kivity <avi@qumranet.com>
Cc: Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] Make LIST_POISON less deadly (v3)
Date: Tue, 20 May 2008 13:55:01 +0200 [thread overview]
Message-ID: <20080520115501.GA6045@elte.hu> (raw)
In-Reply-To: <1211283565-30671-1-git-send-email-avi@qumranet.com>
* Avi Kivity <avi@qumranet.com> wrote:
> The list macros use LIST_POISON1 and LIST_POISON2 as undereferencable
> pointers in order to trap erronous use of freed list_heads.
> Unfortunately userspace can arrange for those pointers to actually be
> dereferencable, potentially turning an oops to an expolit.
>
> To avoid this allow architectures (currently x86_64 only) to override
> the default values for these pointers with truly-undereferncable
> values. This is easy on x86_64 as the virtual address space is large
> and contains unmapped ranges.
looks good - thanks Avi - i've added your patch to the -tip tree. I have
opened a separate topic for it: tip/safe-poison-pointers. (because it
affects other architectures as well)
Ingo
next prev parent reply other threads:[~2008-05-20 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 11:39 [PATCH] Make LIST_POISON less deadly (v3) Avi Kivity
2008-05-20 11:55 ` Ingo Molnar [this message]
2008-05-20 15:15 ` Andi Kleen
2008-05-20 15:17 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520115501.GA6045@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=avi@qumranet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox