public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: yhlu.kernel@gmail.com
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: process fam 10h like k8 with fixed mtrr setting
Date: Tue, 20 May 2008 14:54:44 +0200	[thread overview]
Message-ID: <20080520125443.GA4052@ucw.cz> (raw)
In-Reply-To: <200805051557.38556.yhlu.kernel@gmail.com>

On Mon 2008-05-05 15:57:38, Yinghai Lu wrote:
> 
> otherwise fixed MTRR for family 10h may not be changed
> 
> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
> 
> Index: linux-2.6/arch/x86/kernel/cpu/mtrr/generic.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/cpu/mtrr/generic.c
> +++ linux-2.6/arch/x86/kernel/cpu/mtrr/generic.c
> @@ -342,7 +342,7 @@ static void set_fixed_range(int msr, boo
>  
>  	if (lo != msrwords[0] || hi != msrwords[1]) {
>  		if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD &&
> -		    boot_cpu_data.x86 == 15 &&
> +		    (boot_cpu_data.x86 >= 0x0f && boot_cpu_data.x86 <= 0x11) &&
>  		    ((msrwords[0] | msrwords[1]) & K8_MTRR_RDMEM_WRMEM_MASK))
>  			k8_enable_fixed_iorrs();
>  		mtrr_wrmsr(msr, msrwords[0], msrwords[1]);

This also changes family 0x11. Is that ok?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2008-05-20 12:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05 22:57 [PATCH] x86: process fam 10h like k8 with fixed mtrr setting Yinghai Lu
2008-05-06 12:40 ` Ingo Molnar
2008-05-20 12:54 ` Pavel Machek [this message]
2008-05-20 17:24   ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080520125443.GA4052@ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox