From: Dave Jones <davej@redhat.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
hpa@zytor.com
Subject: Re: [X86] Add recent Centaur CPUs to PAT whitelist
Date: Tue, 20 May 2008 09:19:43 -0400 [thread overview]
Message-ID: <20080520131943.GA4843@redhat.com> (raw)
In-Reply-To: <86802c440805192249y77e78918u8392f5a43331365@mail.gmail.com>
On Mon, May 19, 2008 at 10:49:28PM -0700, Yinghai Lu wrote:
> > + case X86_VENDOR_CENTAUR:
> > + if ((c->x86 > 6) || (c->x86 == 6 && c->x86_model >= 10))
> > + set_cpu_cap(c, X86_FEATURE_PAT);
> > + break;
> > }
> >
> > pat_disable(cpu_has_pat ?
>
> you may need to return early...
Argh, old version of the patch. This one should be right.
Dave
---
>From conversation with Centaur engineers, both the newer generations
of the VIA C7, and their future CPUs support PAT, with no known errata.
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/arch/x86/kernel/cpu/addon_cpuid_features.c b/arch/x86/kernel/cpu/addon_cpuid_features.c
index c2e1ce3..b9f14f9 100644
--- a/arch/x86/kernel/cpu/addon_cpuid_features.c
+++ b/arch/x86/kernel/cpu/addon_cpuid_features.c
@@ -62,6 +62,10 @@ void __cpuinit validate_pat_support(struct cpuinfo_x86 *c)
if (c->x86 == 0xF || (c->x86 == 6 && c->x86_model >= 15))
return;
break;
+ case X86_VENDOR_CENTAUR:
+ if ((c->x86 > 6) || (c->x86 == 6 && c->x86_model >= 10))
+ return;
+ break;
}
pat_disable(cpu_has_pat ?
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2008-05-20 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 4:09 [X86] Add recent Centaur CPUs to PAT whitelist Dave Jones
2008-05-20 5:49 ` Yinghai Lu
2008-05-20 13:19 ` Dave Jones [this message]
2008-05-21 23:56 ` H. Peter Anvin
2008-05-22 14:07 ` Dave Jones
2008-05-22 16:48 ` H. Peter Anvin
2008-05-22 17:02 ` Dave Jones
2008-05-22 20:23 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520131943.GA4843@redhat.com \
--to=davej@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox