From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Tejun Heo <htejun@gmail.com>,
linux-ide@vger.kernel.org, Jeff Garzik <jeff@garzik.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixups to ATA ACPI hotplug
Date: Tue, 20 May 2008 14:22:17 +0100 [thread overview]
Message-ID: <20080520132217.GA5633@srcf.ucam.org> (raw)
In-Reply-To: <20080520131831.GA568@homac>
On Tue, May 20, 2008 at 03:18:32PM +0200, Holger Macht wrote:
> + if (kobj && !is_dock_event) {
> + sprintf(event_string, "BAY_EVENT=%d", event);
> + kobject_uevent_env(kobj, KOBJ_CHANGE, envp);
I think we want to do the _EJ0 checking before this, otherwise we'll
generate two uevents for the same removal on some hardware. Otherwise,
looks good.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-05-20 13:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080505223357.GA2839@srcf.ucam.org>
[not found] ` <20080506081347.GA8688@homac>
[not found] ` <20080506082110.GA10355@srcf.ucam.org>
[not found] ` <48201987.4020009@gmail.com>
[not found] ` <20080506092653.GB4378@homac>
[not found] ` <20080506093628.GA12469@srcf.ucam.org>
2008-05-19 16:29 ` [PATCH] Fixups to ATA ACPI hotplug Matthew Garrett
2008-05-20 7:44 ` Holger Macht
2008-05-20 10:20 ` Matthew Garrett
2008-05-20 13:18 ` Holger Macht
2008-05-20 13:22 ` Matthew Garrett [this message]
2008-05-20 13:58 ` Holger Macht
2008-05-20 14:00 ` Matthew Garrett
2008-05-21 22:26 ` Andrew Morton
2008-05-20 8:49 ` Holger Macht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520132217.GA5633@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox