From: Christoph Hellwig <hch@infradead.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Tom Spink <tspink@gmail.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH] Introduce filesystem type tracking
Date: Tue, 20 May 2008 09:57:32 -0400 [thread overview]
Message-ID: <20080520135732.GA30349@infradead.org> (raw)
In-Reply-To: <20080520134306.GA28946@ZenIV.linux.org.uk>
On Tue, May 20, 2008 at 02:43:06PM +0100, Al Viro wrote:
> No, you have not and no, doing that anywhere near that layer is hopeless.
>
> a) Instances of filesystem can easily outlive all vfsmounts,
> let alone their attachment to namespaces.
> b) What should happen if init is done in the middle of exit?
> c) Why do we need to bother, anyway?
We had a discussion about filesystems starting threads without an
active instance. I suggested tracking instances and add ->init / ->exit
methods to struct file_system_type for these kinds of instances.
But we should track superblock instances, not vfsmount instances of
course. Tom, you probably don't even need a counter, emptyness
of file_system_type.fs_supers should be indication enough. And yes
we'd need locking to prevent init racing with exit.
next prev parent reply other threads:[~2008-05-20 13:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 11:22 [RFC PATCH] Introduce filesystem type tracking Tom Spink
2008-05-20 13:06 ` Tom Spink
2008-05-20 13:43 ` Al Viro
2008-05-20 13:50 ` Tom Spink
2008-05-20 13:57 ` Christoph Hellwig [this message]
2008-05-20 15:18 ` Tom Spink
2008-05-20 15:34 ` Matthew Wilcox
2008-05-20 15:36 ` Tom Spink
2008-05-20 21:08 ` Tom Spink
2008-05-20 22:00 ` Matthew Wilcox
2008-05-20 22:22 ` Tom Spink
2008-05-21 14:49 ` Tom Spink
2008-05-21 9:42 ` Jan Engelhardt
2026-02-18 9:49 ` Christian Brauner
2026-02-19 5:51 ` Christoph Hellwig
2026-02-19 8:04 ` Christian Brauner
2026-02-19 8:45 ` Christian Brauner
2026-02-20 5:43 ` David Timber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520135732.GA30349@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tspink@gmail.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox