From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932322AbYETOB0 (ORCPT ); Tue, 20 May 2008 10:01:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755328AbYETOBO (ORCPT ); Tue, 20 May 2008 10:01:14 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:33407 "EHLO vavatch.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754204AbYETOBM (ORCPT ); Tue, 20 May 2008 10:01:12 -0400 Date: Tue, 20 May 2008 15:00:59 +0100 From: Matthew Garrett To: Tejun Heo , linux-ide@vger.kernel.org, Jeff Garzik , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20080520140059.GA6471@srcf.ucam.org> References: <20080506082110.GA10355@srcf.ucam.org> <48201987.4020009@gmail.com> <20080506092653.GB4378@homac> <20080506093628.GA12469@srcf.ucam.org> <20080519162934.GA15623@srcf.ucam.org> <20080520074442.GA14417@homac> <20080520102038.GA2441@srcf.ucam.org> <20080520131831.GA568@homac> <20080520132217.GA5633@srcf.ucam.org> <20080520135828.GA3167@homac> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080520135828.GA3167@homac> User-Agent: Mutt/1.5.12-2006-07-14 X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@codon.org.uk Subject: Re: [PATCH] Fixups to ATA ACPI hotplug X-SA-Exim-Version: 4.2.1 (built Tue, 20 Jun 2006 01:35:45 +0000) X-SA-Exim-Scanned: Yes (on vavatch.codon.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 20, 2008 at 03:58:30PM +0200, Holger Macht wrote: > Handle bay devices in dock stations > > * Differentiate between bay devices in dock stations and others: > > - When an ACPI_NOTIFY_EJECT_REQUEST appears, just signal uevent to > userspace (that is when the optional eject button on a bay device is > pressed/pulled) giving the possibility to unmount file systems and to > clean up. Also, only send uevent in case we get an EJECT_REQUEST > without doing anything else. In other cases, you'll get an add/remove > event because libata attaches/detaches the device. > > - In case of a dock event, which in turn signals an > ACPI_NOTIFY_EJECT_REQUEST, immediately detach the device, because it > may already have been gone > > * In case of an ACPI_NOTIFY_DEVICE/BUS_CHECK, evaluate _STA to check if > the device has been plugged or unplugged. If plugged, hotplug it, if > unplugged, just signal event to userspace > (initial patch by Matthew Garrett ) > > Signed-off-by: Holger Macht As long as this fixes the hang on dock removal, this looks good to me. Acked-by: Matthew Garrett -- Matthew Garrett | mjg59@srcf.ucam.org