From: Arjan van de Ven <arjan@infradead.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: blk_queue_bounce_limits can actually sleep
Date: Tue, 20 May 2008 14:02:41 -0700 [thread overview]
Message-ID: <20080520140241.1c7e018c@infradead.org> (raw)
In-Reply-To: <20080520195857.GC22369@kernel.dk>
On Tue, 20 May 2008 21:58:57 +0200
> Yeah, THAT I agree with in genereal, but it's probably too much here
> since most callers will not block and probably do call it under the
> queue lock already (just guessing here, didn't audit any callers).
>
> > but it's all vague and waffly because Arjan forgot to tell us why
> > he's bothering to patch this code at all???
>
> Probably the math still isn't quite correct, so it ends up setting up
> the isa pool for no good reason :-(
>
well either it sleeps or it doesn't.....
if this guy should sleep (and right now it does) we shouldn't call it
from such contexts.
If we do the right thing and allocate the isa pools in a sane context,
it wouldn't ever sleep and the patch isn't needed...
next prev parent reply other threads:[~2008-05-20 21:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 3:24 [PATCH] block: blk_queue_bounce_limits can actually sleep Arjan van de Ven
2008-05-20 19:29 ` Jens Axboe
2008-05-20 19:45 ` Andrew Morton
2008-05-20 19:58 ` Jens Axboe
2008-05-20 21:02 ` Arjan van de Ven [this message]
2008-05-20 20:03 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520140241.1c7e018c@infradead.org \
--to=arjan@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox