Re: [BISECTED] pata_jmicron: no drives found on post 2.6.25 kernels

Re: [BISECTED] pata_jmicron: no drives found on post 2.6.25 kernels

[Shaohua Li]

On Tue, 2008-05-20 at 01:37 +0300, Plamen Petrov wrote:
> Hello, folks! 
> 
> After 2.6.26 merge window opened, the optical drives in my
> computer, hanging off a JMicron controler were not detected
> by linux any more. 
> 
> Luca Tettamanti reported similar troubles:
> http://marc.info/?l=linux-kernel&m=120958791323911&w=2 
> 
> Its been 20 days, so I decided to bisect.
> git bisect revealed that commit
> 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
> is the one causing pata_jmicron to fail to detect drives,
> connected to the JMicron controler on my motherboard.
> At least in my case, anyway...
> Changing kernel config to CONFIG_PCIEASPM=n makes the drives
> attached to the JMicron SATA/PATA controller usable again. 
When you enable this option, did you change any ASPM policy? By default,
we are using the BIOS setting, so it shouldn't change any thing.

Also can you please send me the 'lspci -vvvxxxx' output with/without the
ASPM enabled?

Thanks,
Shaohua

Re: [BISECTED] pata_jmicron: no drives found on post 2.6.25 kernels

[Alan Cox]

On Tue, May 20, 2008 at 01:37:14AM +0300, Plamen Petrov wrote:
> git bisect revealed that commit
> 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
> is the one causing pata_jmicron to fail to detect drives,
> connected to the JMicron controler on my motherboard.
> At least in my case, anyway...
> Changing kernel config to CONFIG_PCIEASPM=n makes the drives
> attached to the JMicron SATA/PATA controller usable again. 

The PCIE ASM stuff is experimental and for good reason it appears.

Not an ATA layer bug - a PCIE one so once the PCIE folks fix their stuff
hopefully it'll magically start working.

Re: [BISECTED] pata_jmicron: no drives found on post 2.6.25 kernels

[Plamen Petrov]

[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]

Shaohua Li написа: 

> On Tue, 2008-05-20 at 01:37 +0300, Plamen Petrov wrote:
>> Hello, folks!  
>> 
>> After 2.6.26 merge window opened, the optical drives in my
>> computer, hanging off a JMicron controler were not detected
>> by linux any more.  
>> 
>> Luca Tettamanti reported similar troubles:
>> http://marc.info/?l=linux-kernel&m=120958791323911&w=2  
>> 
>> Its been 20 days, so I decided to bisect.
>> git bisect revealed that commit
>> 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
>> is the one causing pata_jmicron to fail to detect drives,
>> connected to the JMicron controler on my motherboard.
>> At least in my case, anyway...
>> Changing kernel config to CONFIG_PCIEASPM=n makes the drives
>> attached to the JMicron SATA/PATA controller usable again. 
> When you enable this option, did you change any ASPM policy? By default,
> we are using the BIOS setting, so it shouldn't change any thing. 
> 

No, I did not change any ASPM policy, mainly because I do not how. 

> Also can you please send me the 'lspci -vvvxxxx' output with/without the
> ASPM enabled? 
> 

Checkout the attached files. Sorry for the delay - I was away from the
machine in question. 

> Thanks,
> Shaohua 
> 

Thanks for your time,
Plamen 

-- 
Plamen Petrov, network & system administrator
Filial - Silistra
RU "Angel Kantchev"
http://fs.ru.acad.bg/
 --------------------------------
this message is UTF8 encoded 

_
___
_____
 ------------------------------------------
This message was sent by the mail server
at fs.ru.acad.bg using the web interface:
    https://fs.ru.acad.bg/s/m/webmail
E-mail postmaster@fs.ru.acad.bg with anything,
regarding the server itself

[-- Attachment #2: PCIEASPM_DISABLED_lspci.txt.bz2 --]
[-- Type: application/octet-stream, Size: 6596 bytes --]

[-- Attachment #3: PCIEASPM_ENABLED_lspci.txt.bz2 --]
[-- Type: application/octet-stream, Size: 6591 bytes --]

Re: [BISECTED] pata_jmicron: no drives found on post 2.6.25 kernels

[Shaohua Li]

On Tue, 2008-05-20 at 19:09 +0300, Plamen Petrov wrote:
> Shaohua Li написа: 
> 
> > On Tue, 2008-05-20 at 01:37 +0300, Plamen Petrov wrote:
> >> Hello, folks!  
> >> 
> >> After 2.6.26 merge window opened, the optical drives in my
> >> computer, hanging off a JMicron controler were not detected
> >> by linux any more.  
> >> 
> >> Luca Tettamanti reported similar troubles:
> >> http://marc.info/?l=linux-kernel&m=120958791323911&w=2  
> >> 
> >> Its been 20 days, so I decided to bisect.
> >> git bisect revealed that commit
> >> 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
> >> is the one causing pata_jmicron to fail to detect drives,
> >> connected to the JMicron controler on my motherboard.
> >> At least in my case, anyway...
> >> Changing kernel config to CONFIG_PCIEASPM=n makes the drives
> >> attached to the JMicron SATA/PATA controller usable again. 
> > When you enable this option, did you change any ASPM policy? By default,
> > we are using the BIOS setting, so it shouldn't change any thing. 
> > 
> 
> No, I did not change any ASPM policy, mainly because I do not how. 
> 
> > Also can you please send me the 'lspci -vvvxxxx' output with/without the
> > ASPM enabled? 
> > 
Can you please try below patch?
The Slot 03:00.* of JMicron controller has two functions, but one is
PCIE endpoint the other isn't PCIE device, very strange. PCIE spec
defines all functions should have the same config for ASPM, so disable
ASPM for the whole slot in this case.

Signed-off-by: Shaohua Li <shaohua.li@intel.com>

Index: linux/drivers/pci/pcie/aspm.c
===================================================================
--- linux.orig/drivers/pci/pcie/aspm.c	2008-05-21 16:38:17.000000000 +0800
+++ linux/drivers/pci/pcie/aspm.c	2008-05-21 16:52:35.000000000 +0800
@@ -506,6 +506,23 @@ static void free_link_state(struct pci_d
 	pdev->link_state = NULL;
 }
 
+static int pcie_aspm_sanity_check(struct pci_dev *pdev)
+{
+	struct pci_dev *child_dev;
+	int child_pos;
+
+	/*
+	 * Some functions in a slot might not all be PCIE functions, very
+	 * strange. Disable ASPM for the whole slot
+	 */
+	list_for_each_entry(child_dev, &pdev->subordinate->devices, bus_list) {
+		child_pos = pci_find_capability(child_dev, PCI_CAP_ID_EXP);
+		if (!child_pos)
+			return -EINVAL;
+	}
+	return 0;
+}
+
 /*
  * pcie_aspm_init_link_state: Initiate PCI express link state.
  * It is called after the pcie and its children devices are scaned.
@@ -526,6 +543,9 @@ void pcie_aspm_init_link_state(struct pc
 	if (list_empty(&pdev->subordinate->devices))
 		goto out;
 
+	if (pcie_aspm_sanity_check(pdev))
+		goto out;
+
 	mutex_lock(&aspm_lock);
 
 	link_state = kzalloc(sizeof(*link_state), GFP_KERNEL);

Re: [BISECTED] pata_jmicron: no drives found on post 2.6.25 kernels

[Plamen Petrov]

Shaohua Li написа: 

> On Tue, 2008-05-20 at 19:09 +0300, Plamen Petrov wrote:
>> Shaohua Li написа:  
>> 
>> > On Tue, 2008-05-20 at 01:37 +0300, Plamen Petrov wrote:
>> >> Hello, folks!  
>> >> 
>> >> After 2.6.26 merge window opened, the optical drives in my
>> >> computer, hanging off a JMicron controler were not detected
>> >> by linux any more.  
>> >> 
>> >> Luca Tettamanti reported similar troubles:
>> >> http://marc.info/?l=linux-kernel&m=120958791323911&w=2  
>> >> 
>> >> Its been 20 days, so I decided to bisect.
>> >> git bisect revealed that commit
>> >> 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
>> >> is the one causing pata_jmicron to fail to detect drives,
>> >> connected to the JMicron controler on my motherboard.
>> >> At least in my case, anyway...
>> >> Changing kernel config to CONFIG_PCIEASPM=n makes the drives
>> >> attached to the JMicron SATA/PATA controller usable again. 
>> > When you enable this option, did you change any ASPM policy? By default,
>> > we are using the BIOS setting, so it shouldn't change any thing. 
>> >  
>> 
>> No, I did not change any ASPM policy, mainly because I do not how.  
>> 
>> > Also can you please send me the 'lspci -vvvxxxx' output with/without the
>> > ASPM enabled? 
>> > 
> Can you please try below patch?
> The Slot 03:00.* of JMicron controller has two functions, but one is
> PCIE endpoint the other isn't PCIE device, very strange. PCIE spec
> defines all functions should have the same config for ASPM, so disable
> ASPM for the whole slot in this case. 
> 

With the provided patch applied on top of latest git tree, the optical
drive connected to the JMicron controller WORKS with CONFIG_PCIEASPM=y. 

Just in case - this is on a Gigabyte GA-P35-DS3R v2.1 motherboard,
BIOS F11. 

Thanks! 


Plamen Petrov, network & system administrator
Filial - Silistra
RU "Angel Kantchev"
http://fs.ru.acad.bg/
 --------------------------------
this message is UTF8 encoded 

_
___
_____
 ------------------------------------------
This message was sent by the mail server
at fs.ru.acad.bg using the web interface:
    https://fs.ru.acad.bg/s/m/webmail
E-mail postmaster@fs.ru.acad.bg with anything,
regarding the server itself

Re: [BISECTED] pata_jmicron: no drives found on post 2.6.25 kernels

[Luca Tettamanti]

[-- Attachment #1: Type: text/plain, Size: 1639 bytes --]

On Wed, May 21, 2008 at 10:58 AM, Shaohua Li <shaohua.li@intel.com> wrote:
> On Tue, 2008-05-20 at 19:09 +0300, Plamen Petrov wrote:
>> Shaohua Li написа:
>>
>> > On Tue, 2008-05-20 at 01:37 +0300, Plamen Petrov wrote:
>> >> Hello, folks!
>> >>
>> >> After 2.6.26 merge window opened, the optical drives in my
>> >> computer, hanging off a JMicron controler were not detected
>> >> by linux any more.
>> >>
>> >> Luca Tettamanti reported similar troubles:
>> >> http://marc.info/?l=linux-kernel&m=120958791323911&w=2
>> >>
>> >> Its been 20 days, so I decided to bisect.
>> >> git bisect revealed that commit
>> >> 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
>> >> is the one causing pata_jmicron to fail to detect drives,
>> >> connected to the JMicron controler on my motherboard.
>> >> At least in my case, anyway...
>> >> Changing kernel config to CONFIG_PCIEASPM=n makes the drives
>> >> attached to the JMicron SATA/PATA controller usable again.
>> > When you enable this option, did you change any ASPM policy? By default,
>> > we are using the BIOS setting, so it shouldn't change any thing.
>> >
>>
>> No, I did not change any ASPM policy, mainly because I do not how.
>>
>> > Also can you please send me the 'lspci -vvvxxxx' output with/without the
>> > ASPM enabled?
>> >
> Can you please try below patch?

I confirm that the patch fixes the issue when CONFIG_ASPM is enabled.

> The Slot 03:00.* of JMicron controller has two functions, but one is
> PCIE endpoint the other isn't PCIE device, very strange.

Right, that's what I'm seeing here (motherboard is an ASUS P5B-E). I'm
attaching the output of lspci.

thanks,
Luca

[-- Attachment #2: aspm --]
[-- Type: application/octet-stream, Size: 4048 bytes --]

02:00.0 SATA controller: JMicron Technologies, Inc. JMicron 20360/20363 AHCI Controller (rev 02) (prog-if 01 [AHCI 1.0])
	Subsystem: ASUSTeK Computer Inc. Unknown device 81e4
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0, Cache Line Size: 32 bytes
	Interrupt: pin A routed to IRQ 16
	Region 5: Memory at ff3fe000 (32-bit, non-prefetchable) [size=8K]
	Expansion ROM at ff3e0000 [disabled] [size=64K]
	Capabilities: [68] Power Management version 2
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot+,D3cold-)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME-
	Capabilities: [50] Express (v1) Legacy Endpoint, MSI 01
		DevCap:	MaxPayload 128 bytes, PhantFunc 0, Latency L0s <64ns, L1 <1us
			ExtTag- AttnBtn- AttnInd- PwrInd- RBE- FLReset-
		DevCtl:	Report errors: Correctable- Non-Fatal- Fatal- Unsupported-
			RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
			MaxPayload 128 bytes, MaxReadReq 512 bytes
		DevSta:	CorrErr- UncorrErr- FatalErr- UnsuppReq+ AuxPwr- TransPend-
		LnkCap:	Port #1, Speed 2.5GT/s, Width x1, ASPM L0s, Latency L0 <1us, L1 <16us
			ClockPM- Suprise- LLActRep- BwNot-
		LnkCtl:	ASPM Disabled; RCB 64 bytes Disabled- Retrain- CommClk+
			ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
		LnkSta:	Speed 2.5GT/s, Width x1, TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
	Kernel driver in use: ahci
	Kernel modules: ahci
00: 7b 19 63 23 07 00 10 00 02 01 06 01 08 00 80 00
10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
20: 00 00 00 00 00 e0 3f ff 00 00 00 00 43 10 e4 81
30: 00 00 3e ff 68 00 00 00 00 00 00 00 0b 01 00 00
40: bf a1 c2 80 88 88 ff f0 20 00 00 24 02 00 00 00
50: 10 00 11 02 00 00 00 00 00 20 08 00 11 44 02 01
60: 40 00 11 10 00 00 00 00 01 50 02 40 00 00 00 00
70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
80: 08 08 00 00 a0 01 0a 00 0f aa 0f aa 00 00 00 00
90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80
c0: c3 8b 38 00 03 45 02 00 9c 34 27 c0 49 be 00 00
d0: 18 00 80 80 01 00 00 00 01 00 eb 00 00 00 00 56
e0: 00 00 00 00 00 00 00 00 9c 34 27 c0 49 be 00 89
f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

02:00.1 IDE interface: JMicron Technologies, Inc. JMicron 20360/20363 AHCI Controller (rev 02) (prog-if 85 [Master SecO PriO])
	Subsystem: ASUSTeK Computer Inc. Unknown device 81e4
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0
	Interrupt: pin B routed to IRQ 17
	Region 0: I/O ports at ac00 [size=8]
	Region 1: I/O ports at a880 [size=4]
	Region 2: I/O ports at a800 [size=8]
	Region 3: I/O ports at a480 [size=4]
	Region 4: I/O ports at a400 [size=16]
	Capabilities: [68] Power Management version 2
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME-
	Kernel driver in use: pata_jmicron
	Kernel modules: pata_jmicron
00: 7b 19 63 23 07 00 10 00 02 85 01 01 00 00 00 00
10: 41 ac 00 00 81 a8 00 00 01 a8 00 00 81 a4 00 00
20: 01 a4 00 00 00 00 00 00 00 00 00 00 43 10 e4 81
30: 00 00 00 00 68 00 00 00 00 00 00 00 00 02 00 00
40: bf a1 c2 80 88 88 ff f0 20 00 00 24 02 00 00 00
50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
60: 00 00 00 00 00 00 00 00 01 00 02 00 00 00 00 00
70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
80: 08 08 00 00 a0 01 0a 00 0f aa 0f aa 00 00 00 00
90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80
c0: c3 8b 38 00 03 45 02 00 9c 34 27 c0 49 be 00 00
d0: 18 00 80 80 01 00 00 00 01 00 eb 00 00 00 00 56
e0: 00 00 00 00 00 00 00 00 9c 34 27 c0 49 be 00 89
f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00


[-- Attachment #3: noaspm --]
[-- Type: application/octet-stream, Size: 4048 bytes --]

02:00.0 SATA controller: JMicron Technologies, Inc. JMicron 20360/20363 AHCI Controller (rev 02) (prog-if 01 [AHCI 1.0])
	Subsystem: ASUSTeK Computer Inc. Unknown device 81e4
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0, Cache Line Size: 32 bytes
	Interrupt: pin A routed to IRQ 16
	Region 5: Memory at ff3fe000 (32-bit, non-prefetchable) [size=8K]
	Expansion ROM at ff3e0000 [disabled] [size=64K]
	Capabilities: [68] Power Management version 2
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot+,D3cold-)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME-
	Capabilities: [50] Express (v1) Legacy Endpoint, MSI 01
		DevCap:	MaxPayload 128 bytes, PhantFunc 0, Latency L0s <64ns, L1 <1us
			ExtTag- AttnBtn- AttnInd- PwrInd- RBE- FLReset-
		DevCtl:	Report errors: Correctable- Non-Fatal- Fatal- Unsupported-
			RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
			MaxPayload 128 bytes, MaxReadReq 512 bytes
		DevSta:	CorrErr- UncorrErr- FatalErr- UnsuppReq+ AuxPwr- TransPend-
		LnkCap:	Port #1, Speed 2.5GT/s, Width x1, ASPM L0s, Latency L0 <1us, L1 <16us
			ClockPM- Suprise- LLActRep- BwNot-
		LnkCtl:	ASPM Disabled; RCB 64 bytes Disabled- Retrain- CommClk+
			ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
		LnkSta:	Speed 2.5GT/s, Width x1, TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
	Kernel driver in use: ahci
	Kernel modules: ahci
00: 7b 19 63 23 07 00 10 00 02 01 06 01 08 00 80 00
10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
20: 00 00 00 00 00 e0 3f ff 00 00 00 00 43 10 e4 81
30: 00 00 3e ff 68 00 00 00 00 00 00 00 0b 01 00 00
40: bf a1 c2 80 a8 a8 ff f0 20 00 00 24 02 00 00 00
50: 10 00 11 02 00 00 00 00 00 20 08 00 11 44 02 01
60: 40 00 11 10 00 00 00 00 01 50 02 40 00 00 00 00
70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
80: 08 08 00 00 a0 01 0a 00 0f aa 0f aa 00 00 00 00
90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80
c0: c3 8b 38 00 03 45 02 00 9c 34 27 c0 49 be 00 00
d0: 18 00 80 80 01 00 00 00 01 00 eb 00 00 00 00 56
e0: 00 00 00 00 00 00 00 00 9c 34 27 c0 49 be 00 89
f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

02:00.1 IDE interface: JMicron Technologies, Inc. JMicron 20360/20363 AHCI Controller (rev 02) (prog-if 85 [Master SecO PriO])
	Subsystem: ASUSTeK Computer Inc. Unknown device 81e4
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0
	Interrupt: pin B routed to IRQ 17
	Region 0: I/O ports at ac00 [size=8]
	Region 1: I/O ports at a880 [size=4]
	Region 2: I/O ports at a800 [size=8]
	Region 3: I/O ports at a480 [size=4]
	Region 4: I/O ports at a400 [size=16]
	Capabilities: [68] Power Management version 2
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME-
	Kernel driver in use: pata_jmicron
	Kernel modules: pata_jmicron
00: 7b 19 63 23 07 00 10 00 02 85 01 01 00 00 00 00
10: 01 ac 00 00 81 a8 00 00 01 a8 00 00 81 a4 00 00
20: 01 a4 00 00 00 00 00 00 00 00 00 00 43 10 e4 81
30: 00 00 00 00 68 00 00 00 00 00 00 00 00 02 00 00
40: bf a1 c2 80 a8 a8 ff f0 20 00 00 24 02 00 00 00
50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
60: 00 00 00 00 00 00 00 00 01 00 02 00 00 00 00 00
70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
80: 08 08 00 00 a0 01 0a 00 0f aa 0f aa 00 00 00 00
90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80
c0: c3 8b 38 00 03 45 02 00 9c 34 27 c0 49 be 00 00
d0: 18 00 80 80 01 00 00 00 01 00 eb 00 00 00 00 56
e0: 00 00 00 00 00 00 00 00 9c 34 27 c0 49 be 00 89
f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

Re: [BISECTED] pata_jmicron: no drives found on post 2.6.25 kernels

[Shaohua Li]

On Wed, 2008-05-21 at 21:45 +0200, Luca Tettamanti wrote:
> On Wed, May 21, 2008 at 10:58 AM, Shaohua Li <shaohua.li@intel.com> wrote:
> > On Tue, 2008-05-20 at 19:09 +0300, Plamen Petrov wrote:
> >> Shaohua Li написа:
> >>
> >> > On Tue, 2008-05-20 at 01:37 +0300, Plamen Petrov wrote:
> >> >> Hello, folks!
> >> >>
> >> >> After 2.6.26 merge window opened, the optical drives in my
> >> >> computer, hanging off a JMicron controler were not detected
> >> >> by linux any more.
> >> >>
> >> >> Luca Tettamanti reported similar troubles:
> >> >> http://marc.info/?l=linux-kernel&m=120958791323911&w=2
> >> >>
> >> >> Its been 20 days, so I decided to bisect.
> >> >> git bisect revealed that commit
> >> >> 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
> >> >> is the one causing pata_jmicron to fail to detect drives,
> >> >> connected to the JMicron controler on my motherboard.
> >> >> At least in my case, anyway...
> >> >> Changing kernel config to CONFIG_PCIEASPM=n makes the drives
> >> >> attached to the JMicron SATA/PATA controller usable again.
> >> > When you enable this option, did you change any ASPM policy? By default,
> >> > we are using the BIOS setting, so it shouldn't change any thing.
> >> >
> >>
> >> No, I did not change any ASPM policy, mainly because I do not how.
> >>
> >> > Also can you please send me the 'lspci -vvvxxxx' output with/without the
> >> > ASPM enabled?
> >> >
> > Can you please try below patch?
> 
> I confirm that the patch fixes the issue when CONFIG_ASPM is enabled.
> 
> > The Slot 03:00.* of JMicron controller has two functions, but one is
> > PCIE endpoint the other isn't PCIE device, very strange.
> 
> Right, that's what I'm seeing here (motherboard is an ASUS P5B-E). I'm
> attaching the output of lspci.
Jesse, can you take this patch. It should be safe for 2.6.26.

Thanks,
Shaohua

Re: [BISECTED] pata_jmicron: no drives found on post 2.6.25 kernels

[Jesse Barnes]

On Wednesday, May 21, 2008 6:15 pm Shaohua Li wrote:
> On Wed, 2008-05-21 at 21:45 +0200, Luca Tettamanti wrote:
> > On Wed, May 21, 2008 at 10:58 AM, Shaohua Li <shaohua.li@intel.com> wrote:
> > > On Tue, 2008-05-20 at 19:09 +0300, Plamen Petrov wrote:
> > >> Shaohua Li написа:
> > >> > On Tue, 2008-05-20 at 01:37 +0300, Plamen Petrov wrote:
> > >> >> Hello, folks!
> > >> >>
> > >> >> After 2.6.26 merge window opened, the optical drives in my
> > >> >> computer, hanging off a JMicron controler were not detected
> > >> >> by linux any more.
> > >> >>
> > >> >> Luca Tettamanti reported similar troubles:
> > >> >> http://marc.info/?l=linux-kernel&m=120958791323911&w=2
> > >> >>
> > >> >> Its been 20 days, so I decided to bisect.
> > >> >> git bisect revealed that commit
> > >> >> 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
> > >> >> is the one causing pata_jmicron to fail to detect drives,
> > >> >> connected to the JMicron controler on my motherboard.
> > >> >> At least in my case, anyway...
> > >> >> Changing kernel config to CONFIG_PCIEASPM=n makes the drives
> > >> >> attached to the JMicron SATA/PATA controller usable again.
> > >> >
> > >> > When you enable this option, did you change any ASPM policy? By
> > >> > default, we are using the BIOS setting, so it shouldn't change any
> > >> > thing.
> > >>
> > >> No, I did not change any ASPM policy, mainly because I do not how.
> > >>
> > >> > Also can you please send me the 'lspci -vvvxxxx' output with/without
> > >> > the ASPM enabled?
> > >
> > > Can you please try below patch?
> >
> > I confirm that the patch fixes the issue when CONFIG_ASPM is enabled.
> >
> > > The Slot 03:00.* of JMicron controller has two functions, but one is
> > > PCIE endpoint the other isn't PCIE device, very strange.
> >
> > Right, that's what I'm seeing here (motherboard is an ASUS P5B-E). I'm
> > attaching the output of lspci.
>
> Jesse, can you take this patch. It should be safe for 2.6.26.

Definitely.  Thanks Shaohua.

Jesse