public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [X86] Remove unnecessary code in 64bit CPU identification.
Date: Tue, 20 May 2008 11:16:55 -0400	[thread overview]
Message-ID: <20080520151655.GA542@redhat.com> (raw)
In-Reply-To: <4832E461.2070503@zytor.com>

On Tue, May 20, 2008 at 07:46:57AM -0700, H. Peter Anvin wrote:
 > Dave Jones wrote:
 > > There were no 64bit Transmeta CPUs made (and it'd be something of
 > > a surprise if they started any time soon).   To the best of my knowledge,
 > > no CPU vendor cloned the 80860000 cpuid space claimed by Transmeta.
 > > By removing this code, we can also eliminate calling cpuid 0x80000007 twice.
 > > 
 > > Signed-off-by: Dave Jones <davej@redhat.com>
 > 
 > I'd really like to avoid divergences between the 32-bit and 64-bit code 
 > if they can be avoided at this point.  These codes need to be unified, 
 > not further split.

Umm, the 32 bit code has the per-vendor stuff removed from setup.c, and factored
out into per-vendor files in arch/x86/kernel/cpu/  Because the 64bit version
doesn't do that (yet), my removal of this code actually gets us closer to unification.
After my patch, neither of the setup.c files have the Transmeta bits :)

	Dave

-- 
http://www.codemonkey.org.uk

  reply	other threads:[~2008-05-20 15:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20  4:09 [X86] Remove unnecessary code in 64bit CPU identification Dave Jones
2008-05-20  4:14 ` Dave Jones
2008-05-20 14:46 ` H. Peter Anvin
2008-05-20 15:16   ` Dave Jones [this message]
2008-05-20 17:58     ` H. Peter Anvin
2008-05-20 18:06       ` Dave Jones
2008-05-20 19:18       ` Dave Jones
2008-05-20 19:42         ` H. Peter Anvin
2008-05-21 23:55         ` H. Peter Anvin
2008-05-22 14:04           ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080520151655.GA542@redhat.com \
    --to=davej@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox