From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932255AbYETR0X (ORCPT ); Tue, 20 May 2008 13:26:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765175AbYETRZ4 (ORCPT ); Tue, 20 May 2008 13:25:56 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:37786 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764907AbYETRZz (ORCPT ); Tue, 20 May 2008 13:25:55 -0400 Date: Tue, 20 May 2008 10:21:39 -0700 From: Greg KH To: Andrew Morton Cc: Dave Young , matthew@wil.cx, kay.sievers@vrfy.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 1/3][-mm] add class_reclassify macro Message-ID: <20080520172139.GA11666@kroah.com> References: <20080520095553.GA3201@darkstar.te-china.tietoenator.com> <20080520030232.fc91b64e.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080520030232.fc91b64e.akpm@linux-foundation.org> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 20, 2008 at 03:02:32AM -0700, Andrew Morton wrote: > On Tue, 20 May 2008 17:55:54 +0800 Dave Young wrote: > > > Converting class semaphore to mutex cause lockdep warnings due to > > class_interface_register/unregister will possible call device_add/del > > Shouldn't we just fix that? Um, no, that's a "feature" that some types of hardware and interfaces require. This is one reason I really don't like this type of conversion, it's causing lots of problems for no known gain. So I would just recommend dropping this patch set, the current "convert class semaphore to a mutex" patch in the -mm tree is already causing lockdep warnings, and trying to do something like this isn't really going to solve the root problem here. thanks, greg k-h