From: Al Viro <viro@ZenIV.linux.org.uk>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Al Viro <viro@ftp.linux.org.uk>,
mchehab@infradead.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] bt8xx: unaligned access
Date: Wed, 21 May 2008 01:43:06 +0100 [thread overview]
Message-ID: <20080521004306.GC28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1211330323.5915.226.camel@brick>
On Tue, May 20, 2008 at 05:38:43PM -0700, Harvey Harrison wrote:
> > - type = be16_to_cpup((u16*)(ee+4));
> > + type = get_unaligned_be16((__be16 *)(ee+4));
>
> The casts aren't strictly necessary here. Any reason to keep it?
I'd rather have them explicit *and* make get_unaligned_* take the pointer
of right type, so that it'd eat things like void * and __be16 *, but warn
on int * et.al. One too many brainos seen in that area...
next prev parent reply other threads:[~2008-05-21 0:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 0:32 [PATCH] bt8xx: unaligned access Al Viro
2008-05-21 0:38 ` Harvey Harrison
2008-05-21 0:43 ` Al Viro [this message]
2008-05-21 0:45 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521004306.GC28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox