Re: [PATCH] misc drivers/net endianness noise

Al Viro
2008-05-21T00:55:20Z

On Tue, May 20, 2008 at 05:48:00PM -0700, Harvey Harrison wrote:
> I was contemplating an api like:
>
> void put_le16(u16 val, __le16 *ptr)
> {
> *ptr = cpu_to_le16(val);
> }
>
> which would allow the above to become:
>
> if (catc->is_f5u011)
> put_be16(skb->len, tx_buf);
> else
> put_le16(skb->len, tx_buf);
>
> Thoughts?

Do not grow API too much. Mental savings on recognizing what's done are
offset by need to remember more helper functions...