From: Al Viro <viro@ZenIV.linux.org.uk>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Al Viro <viro@ftp.linux.org.uk>,
torvalds@linux-foundation.org, geert@linux-m68k.org,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] provide out-of-line strcat() for m68k
Date: Wed, 21 May 2008 06:30:12 +0100 [thread overview]
Message-ID: <20080521053012.GL28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0805210531170.18184@localhost.localdomain>
On Wed, May 21, 2008 at 05:34:58AM +0200, Roman Zippel wrote:
> Hi,
>
> On Wed, 21 May 2008, Al Viro wrote:
>
> > Whether we sidestep it in init/main.c or not, such situations
> > will arise again; compiler does generate calls of strcat()
> > on optimizations, so we really ought to have an out-of-line
> > version...
>
> It actually was strlen that was generated and not strcat.
Here it replaced strncat() with call of strcat() (gcc 4.0.1, FWIW).
And yes, I can show you init/main.s with
jbsr strcat |
in it generated on kernel in b0rken range...
next prev parent reply other threads:[~2008-05-21 5:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 1:12 [PATCH] provide out-of-line strcat() for m68k Al Viro
2008-05-21 3:34 ` Roman Zippel
2008-05-21 5:30 ` Al Viro [this message]
2008-05-21 10:53 ` Roman Zippel
2008-05-21 11:09 ` Al Viro
2008-05-21 7:52 ` -ffreestanding or not -ffreestanding Adrian Bunk
2008-05-21 11:44 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521053012.GL28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox