public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Christoph Hellwig <hch@infradead.org>,
	Matthew Wilcox <matthew@wil.cx>
Subject: Re: [PATCH] Introduce down_nowait()
Date: Wed, 21 May 2008 04:04:53 -0400	[thread overview]
Message-ID: <20080521080452.GA1305@infradead.org> (raw)
In-Reply-To: <20080520232903.6756b1c1.akpm@linux-foundation.org>

On Tue, May 20, 2008 at 11:29:03PM -0700, Andrew Morton wrote:
> Actually, I don't thing down_nowait() is a terribly good name, because it
> doesn't tell the reader anything about what to expect from the return
> value.  Does a non-zero return mean that down_wait() acquired the lock,
> or does it not?  Something like down_try() would be better, because if
> it returns 1 we can say "ah, the trying succeeded".

Actually, it does, and the kerneldoc comment explains it in every detail
for those who need to read it up.  Then again semaphores and on their
way out, and I really hate the kind of churn this thing introduces at
this moment.  Please let all the semaphore to completion/mutex/other
construct change settle for a while, and with a little chance this gem
will just go away entirely.


  parent reply	other threads:[~2008-05-21  8:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21  6:00 [PATCH] Introduce down_nowait() Rusty Russell
2008-05-21  6:29 ` Andrew Morton
2008-05-21  7:56   ` Rusty Russell
2008-05-21 17:04     ` Daniel Walker
2008-05-22  8:56       ` Rusty Russell
2008-05-22 15:48         ` Daniel Walker
2008-05-23  0:52           ` Rusty Russell
2008-05-21  8:04   ` Christoph Hellwig [this message]
2008-05-21  8:19     ` Andrew Morton
2008-05-21 12:09       ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521080452.GA1305@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=rusty@rustcorp.com.au \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox