Re: [PATCH] Introduce down_nowait()

Daniel Walker
2008-05-22T15:48:58Z

On Thu, 2008-05-22 at 18:56 +1000, Rusty Russell wrote:

> The patches to change down_trylock to down_try touch a heap of files, which
> are also touched in other people's trees. If this patch goes upstream, those
> people rewriting that code can use down_try in their rewrite, and I can throw
> mine away.

Seems like it's too much trouble.. I mean, we're removing semaphores
anyway and down_trylock with them. I'll agree with Andrew down_trylock
removal is pretty glacial. It's cause there aren't many of them and most
of the ones I've looked at are in strange locking schemes, which makes
them difficult to remove..

I'm not against your changes, but if it's going to cause problems I'd
rather people focus on mutex_trylock instead.

Daniel