Re: [PATCH] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

Jean Delvare
2008-05-21T15:10:23Z

On Wed, 21 May 2008 16:33:07 +0200, Wolfram Sang wrote:
> Hi Jochen,
>
> On Wed, May 21, 2008 at 12:43:22PM +0200, Jochen Friedrich wrote:
> > This driver uses the port of 2.4 code from Vitaly Bordug
> > <vitb@kernel.crashing.org> and the actual algorithm used by the i2c
> > driver of the DBox code on cvs.tuxboc.org from Felix Domke
> > (tmbinc@gmx.net) and Gillem (htoa@gmx.net) converted to an
> > of_platform_driver. Tested on CPM1 (MPC823 on dbox2 hardware) and
> > CPM2 (MPC8272).
> >
> > Signed-off-by: Jochen Friedrich <jochen@scram.de>
> > ---
> Works on MPC8260.
>
> Tested-by: Wolfram Sang <w.sang@pengutronix.de>
>
> > drivers/i2c/busses/Kconfig | 10 +
> > drivers/i2c/busses/Makefile | 1 +
> > drivers/i2c/busses/i2c-cpm.c | 745 ++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 756 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/i2c/busses/i2c-cpm.c
> >
> > Changes since last version:
> > - fixed copy and paste bug (I2COM_MASTER -> I2COM_START)
> > - changed dev_err() to dev_dbg() for NACK
> > - changed dev_dbg() to dev_err() for Timeout
> > - added explanation for brg formular
> Typo: formula
>
> > - added "bus-frequency" OF attribute to be able to override i2c clock
> \o/ Cool feature. Worked nicely.
>
> > - support for numbered adapter (it was already documented in
> > my booting-without-of patch but not yet implemented)
> > - finally changed i2c "pseudo address" 0xfe to 0x7f << 1
> > - get rid of the "fsl,cpm-i2c" name. This logic was screwed
> > - fixed the error patch for request_irq failure
>
> path instead of patch? But well, I assume typos in this section do not
> matter much anyhow as they are not imported into git. Am I right, Jean?

Yes you are.

--
Jean Delvare