Re: [-mm][PATCH 2/4] Setup the memrlimit controller (v5)

Balbir Singh
2008-06-12T06:14:19Z

Andrew Morton wrote:
>
> #define PAGE_ALIGN(addr) ALIGN(addr, PAGE_SIZE)
>
> ?
>
> afaict ALIGN() tries to do the right thing, and if it doesn't, we
> should fix ALIGN().
>

That should do the right thing, provided there are no duplicate ALIGN defintions
elsewhere

kernel.h has

#define ALIGN(x,a) __ALIGN_MASK(x,(typeof(x))(a)-1)
#define __ALIGN_MASK(x,mask) (((x)+(mask))&~(mask))

Which seems like the correct thing, since we use typeof(x) for (a) - 1.

--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL