Re: [-mm][PATCH 3/4] cgroup mm owner callback changes to add task info (v5)

Balbir Singh
2008-05-22T10:15:53Z

Andrew Morton wrote:
> On Wed, 21 May 2008 20:59:59 +0530 Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
>> This patch adds an additional field to the mm_owner callbacks. This field
>> is required to get to the mm that changed. Hold mmap_sem in write mode
>> before calling the mm_owner_changed callback
>>
>> ...
>>
>> + * The callbacks are invoked with mmap_sem held in read mode.
>
> Is that true?
>
>> + down_write(&mm->mmap_sem);
>> ...
>> cgroup_mm_owner_callbacks(mm->owner, c);
>
> Looks like write-mode to me?

Yes, obsolete comment. Will fix.

--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL