Re: [-mm][PATCH 2/4] Setup the memrlimit controller (v5)

Balbir Singh
2008-06-11T17:54:33Z

Andrea Righi wrote:
> Balbir Singh wrote:
>> +static int memrlimit_cgroup_write_strategy(char *buf, unsigned long
>> long *tmp)
>> +{
>> + *tmp = memparse(buf, &buf);
>> + if (*buf != '\0')
>> + return -EINVAL;
>> +
>> + *tmp = PAGE_ALIGN(*tmp);
>> + return 0;
>> +}
>
> We shouldn't use PAGE_ALIGN() here, otherwise we limit the address space
> to 4GB on 32-bit architectures (that could be reasonable, because this
> is a per-cgroup limit and not per-process).
>

You mean un-reasonable?

> Signed-off-by: Andrea Righi <righi.andrea@gmail.com>

Seems fair enough.

Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>

--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL