public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Stas Sergeev <stsp@aknet.ru>
Cc: linux-kernel@vger.kernel.org, dbrownell@users.sourceforge.net,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	stable@kernel.org
Subject: Re: [patch] provide rtc_cmos platform device
Date: Wed, 21 May 2008 15:32:23 -0700	[thread overview]
Message-ID: <20080521153223.e989cb88.akpm@linux-foundation.org> (raw)
In-Reply-To: <483317B4.7060601@aknet.ru>

On Tue, 20 May 2008 22:25:56 +0400
Stas Sergeev <stsp@aknet.ru> wrote:

> Hello.
> 
> Recently (around 2.6.25) I've noticed
> that RTC no longer works for me.

So it's a regression.

> It turned out this is because I use
> pnpacpi=off kernel option to work
> around the parport_pc bugs.
> I always did so, but RTC used to work
> fine in the past, and now it have
> regressed.

Albeit a fairly obscure one.  I tagged the patch for backporting, let
those guys decide ;)

> The attached patch fixes the problem
> by creating the platform device for
> the RTC when PNP is disabled.
> This may also help running the
> PNP-enabled kernel on an older PCs.
> 
> Signed-off-by: Stas Sergeev <stsp@aknet.ru>

I suppose that on this basis:

 arch/x86/kernel/rtc.c  |   31 +++++++++++++++++++++++++++++++
 drivers/rtc/rtc-cmos.c |   26 +++++++++-----------------
 include/asm-x86/rtc.h  |    4 ++++

it should be considered an x86 patch.  I shall treat it as such.

Thanks.

  reply	other threads:[~2008-05-21 22:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20 18:25 [patch] provide rtc_cmos platform device Stas Sergeev
2008-05-21 22:32 ` Andrew Morton [this message]
2008-05-22 19:05   ` Stas Sergeev
2008-05-22 19:56     ` David Brownell
2008-05-23  5:12   ` Stas Sergeev
2008-05-21 23:05 ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521153223.e989cb88.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dbrownell@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stable@kernel.org \
    --cc=stsp@aknet.ru \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox