From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935952AbYEURaT (ORCPT ); Wed, 21 May 2008 13:30:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765878AbYEURaE (ORCPT ); Wed, 21 May 2008 13:30:04 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:37790 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753904AbYEURaC (ORCPT ); Wed, 21 May 2008 13:30:02 -0400 Date: Wed, 21 May 2008 10:29:56 -0700 From: Gary Hade To: Jesse Barnes Cc: Gary Hade , Yinghai Lu , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH] PCI: boot parameter to avoid expansion ROM memory allocation Message-ID: <20080521172956.GA8024@us.ibm.com> References: <20080512205746.GB7401@us.ibm.com> <200805201057.49679.jbarnes@virtuousgeek.org> <20080520200049.GA7334@us.ibm.com> <200805201316.33882.jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200805201316.33882.jbarnes@virtuousgeek.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 20, 2008 at 01:16:33PM -0700, Jesse Barnes wrote: > On Tuesday, May 20, 2008 1:00 pm Gary Hade wrote: > > On Tue, May 20, 2008 at 10:57:49AM -0700, Jesse Barnes wrote: > > > On Wednesday, May 14, 2008 9:20 am Gary Hade wrote: > > > > > Correct, not a perfect solution but better than we have right now. > > > > > > > > ...but don't let this comment make you think that I am not in > > > > favor of something like you are suggesting. I am interested > > > > in getting the 'pci=norom' change into mainline quickly but it > > > > is obviously less than ideal for the long term. > > > > > > > > Jesse, any idea how many different devices absolutely need > > > > memory allocated for their expansion ROMs? > > > > > > Unless there's a ton of demand, I'd rather go with the norom option, but > > > either way, I'd like to push the fix early in the 2.6.27 cycle rather > > > than trying to get it into 2.6.26 at the last minute... > > > > This is fine. I would also like to see the pci=norom option > > added as-is with the thought that we may improve later by either > > modifying pci=norom to exclude devices that need memory mapped > > to their expansion ROMs or by adding another option (pci=minrom ?) > > that would do the same thing. > > > > > So assuming you're ok with your last patch, I'll stuff it into > > > linux-next. > > > > Works for me. Thanks. > > Ok, just pushed the norom patch to linux-next. I'll test it out, but it would > be good if you could try the tree out out on one of the problem machines too. Jesse, I just tried 2.6.26-rc3-next-20080521 on one of those systems and the pci=norom option worked as expected. Thanks, Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503 garyhade@us.ibm.com http://www.ibm.com/linux/ltc