Re: [RFC PATCH 0/4] Describe SPI devices in the OF device tree and add mpc5200-spi driver

Jon Smirl
2008-05-16T20:27:42Z

On 5/16/08, Grant Likely <grant.likely@secretlab.ca> wrote:
> This series is a set of changes to allow the slaves on an SPI bus to be
> described in the OF device tree (useful in arch/powerpc) and adds a driver
> that uses it (the Freescale MPC5200 SoC's SPI device).

Right now we have SPI hooked up to PSC3. Hardware engineer is gone but
I'll see if I can get him to alter things to use the SPI controller. I
have an old mail from him where he thinks the Phytec board is missing
a signal needed to use the SPI controller.

Is the current SPI driver working on PSC3? I have a MMC card wired up
to it but I've never tried using it.

I have the MPC5200 PSC SPI driver enabled and "MMC/SD over SPI"
enabled in my kernel. The MMC bus gets created but there aren't any
devices on it. Do we need something in the SPI driver so that the MMC
layer can find it?

Are you going to keeps this as two drivers or merge them? If it is two
drivers there should be one entry in Kconfig and two sub choices for
the types of drivers.

> Please review and comment. David, I've included in this series my earlier
> patch to change modalias from a pointer to a string as one of the later
> patches depends on it.
>
> Cheers,
> g.
>
>
> --
> Grant Likely, B.Sc. P.Eng.
> Secret Lab Technologies Ltd.
>

--
Jon Smirl
jonsmirl@gmail.com