Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration.

Grant Likely
2008-05-24T06:54:40Z

On Sat, May 24, 2008 at 12:43 AM, Grant Likely
<grant.likely@secretlab.ca> wrote:
> On Wed, May 21, 2008 at 6:17 PM, David Brownell <david-b@pacbell.net> wrote:
>> On Friday 16 May 2008, Grant Likely wrote:
>>>
>>> This patch splits the allocation and registration portions of code out
>>> of spi_new_device() and creates three new functions; spi_alloc_device(),
>>> spi_register_device(), and spi_device_release().
>>
>> I have no problem with the first two, but why the last?
>>
>> If the devices are always allocated by spi_alloc_device() as
>> they should be -- probably through an intermediary -- the
>> only public function necessary for that cleanup should be
>> the existing spi_dev_put().
>
> Ah, okay. I'm still a bit fuzzy on the device model conventions.
> I'll remove that then.

Question: spi_alloc_device() (and the original code) does a
spi_master_get() on the spi_master device. Doesn't spi_master_put()
need to be called when the device is discarded? spi_dev_put() doesn't
do that explicitly; is it an implicit operation after a device has
been deregistered from the spi_master?

Thanks,
g.

>
> g.
>
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
>

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.