From: Greg KH <greg@kroah.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Matthew Dharm <mdharm-usb@one-eyed-alien.net>,
"Frank Ch. Eigler" <fche@redhat.com>,
Adrian Bunk <bunk@kernel.org>,
USB Storage list <usb-storage@lists.one-eyed-alien.net>,
Kernel development list <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@sunset.davemloft.net>,
systemtap@sources.redhat.com,
Andrew Morton <akpm@linux-foundation.org>,
linux-cifs-client@lists.samba.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] usb-storage: don't call utsname()
Date: Wed, 21 May 2008 12:35:17 -0700 [thread overview]
Message-ID: <20080521193517.GA4905@kroah.com> (raw)
In-Reply-To: <20080521185251.GA783@infradead.org>
On Wed, May 21, 2008 at 02:52:51PM -0400, Christoph Hellwig wrote:
> On Wed, May 21, 2008 at 11:09:57AM -0700, Greg KH wrote:
> > Why? With this change, if you change the version number, the file will
> > have to be rebuilt. Without the change, the file will not need to be
> > rebuilt, right?
>
> Because thanks to the container patches it utsname fields other than
> hostname can actually change at runtime now and you'll get races looking
> at them. And probably not the output you want if someone in your
> container changes the kernel version to trick applications.
So, do we now go and rip out all usages of utsname()->release and put
back the #define just because of the loonacy of containers?
No kernel should have to change it's version number to trick an
application, why would an application care about the version number to
start with? In the "enterprise kernel" world, version numbers have
little to no relevance on the functionality or features of the kernel,
so any check of something like this is sure to be wrong to start with.
thanks,
greg k-h
next prev parent reply other threads:[~2008-05-21 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 18:29 [2.6 patch] unexport uts_sem Adrian Bunk
2008-05-20 17:16 ` Frank Ch. Eigler
2008-05-20 17:27 ` Christoph Hellwig
2008-05-20 18:38 ` Frank Ch. Eigler
2008-05-21 12:37 ` Christoph Hellwig
2008-05-21 14:48 ` Steve French (smfltc)
2008-05-21 17:51 ` [PATCH] usb-storage: don't call utsname() Alan Stern
2008-05-21 18:09 ` Greg KH
2008-05-21 18:19 ` Steve French (smfltc)
2008-05-21 18:52 ` Christoph Hellwig
2008-05-21 19:35 ` Greg KH [this message]
2008-05-21 21:01 ` Steve French (smfltc)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521193517.GA4905@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=davem@sunset.davemloft.net \
--cc=fche@redhat.com \
--cc=hch@infradead.org \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=stern@rowland.harvard.edu \
--cc=systemtap@sources.redhat.com \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).