From: Andrew Morton <akpm@linux-foundation.org>
To: "Andrew G. Morgan" <morgan@kernel.org>
Cc: Shi Weihua <shiwh@cn.fujitsu.com>,
"Serge E. Hallyn" <serue@us.ibm.com>,
linux-security-module@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
jmorris@namei.org, ltp-list@lists.sourceforge.net
Subject: Re: [PATCH] fix sys_prctl() returned uninitialized value
Date: Wed, 21 May 2008 22:15:36 -0700 [thread overview]
Message-ID: <20080521221536.204da871.akpm@linux-foundation.org> (raw)
In-Reply-To: <4834FE1D.10909@kernel.org>
On Wed, 21 May 2008 22:01:17 -0700 "Andrew G. Morgan" <morgan@kernel.org> wrote:
> this is the default expected by the subsequent switch ().
>
oh gawd.
>
> diff --git a/kernel/sys.c b/kernel/sys.c
> index 895d2d4..cb25a64 100644
> --- a/kernel/sys.c
> +++ b/kernel/sys.c
> @@ -1657,6 +1657,8 @@ asmlinkage long sys_prctl(int option, unsigned long arg2, unsigned long arg3,
> if (security_task_prctl(option, arg2, arg3, arg4, arg5, &error))
> return error;
All along I was believing that it was _this_ return which was causing
the problem.
> + error = 0;
> +
> switch (option) {
> case PR_SET_PDEATHSIG:
> if (!valid_signal(arg2)) {
But now I see it.
This was a hard way to write a changelog.
next prev parent reply other threads:[~2008-05-22 5:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 3:19 [PATCH] fix sys_prctl() returned uninitialized value Shi Weihua
2008-05-22 3:32 ` Andrew Morton
2008-05-22 4:34 ` [LTP] " Li Zefan
2008-05-22 4:57 ` Andrew Morton
2008-05-22 5:01 ` Andrew G. Morgan
2008-05-22 5:15 ` Andrew Morton [this message]
2008-05-22 5:25 ` Andrew Morton
2008-05-22 13:07 ` Andrew G. Morgan
2008-05-22 19:17 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521221536.204da871.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=ltp-list@lists.sourceforge.net \
--cc=morgan@kernel.org \
--cc=serue@us.ibm.com \
--cc=shiwh@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox