From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, pq@iki.fi, proski@gnu.org,
sandmann@redhat.com, a.p.zijlstra@chello.nl,
Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH 5/5] ftrace: remove printks from irqsoff trace
Date: Thu, 22 May 2008 00:22:20 -0400 [thread overview]
Message-ID: <20080522042302.242307072@goodmis.org> (raw)
In-Reply-To: 20080522042215.584408893@goodmis.org
[-- Attachment #1: ftrace-dont-printk-on-max.patch --]
[-- Type: text/plain, Size: 1458 bytes --]
Printing out new max latencies was fine for the old RT tracer. But for
mainline it is a bit messy. We also need to test if the run queue
is locked before we can do the print. This means that we may not be
printing out latencies if the run queue is locked on another CPU.
This produces inconsistencies in the output.
This patch simply removes the print altogether.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
kernel/trace/trace_irqsoff.c | 16 ----------------
1 file changed, 16 deletions(-)
Index: linux-tip.git/kernel/trace/trace_irqsoff.c
===================================================================
--- linux-tip.git.orig/kernel/trace/trace_irqsoff.c 2008-05-21 20:22:27.000000000 -0400
+++ linux-tip.git/kernel/trace/trace_irqsoff.c 2008-05-22 00:11:10.000000000 -0400
@@ -165,22 +165,6 @@ check_critical_timing(struct trace_array
update_max_tr_single(tr, current, cpu);
- if (!runqueue_is_locked()) {
- if (tracing_thresh) {
- printk(KERN_INFO "(%16s-%-5d|#%d): %lu us critical"
- " section violates %lu us threshold.\n",
- current->comm, current->pid,
- raw_smp_processor_id(),
- latency, nsecs_to_usecs(tracing_thresh));
- } else {
- printk(KERN_INFO "(%16s-%-5d|#%d): new %lu us"
- " maximum-latency critical section.\n",
- current->comm, current->pid,
- raw_smp_processor_id(),
- latency);
- }
- }
-
max_sequence++;
out_unlock:
--
prev parent reply other threads:[~2008-05-22 4:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 4:22 [PATCH 0/5] ftrace clean ups Steven Rostedt
2008-05-22 4:22 ` [PATCH 1/5] ftrace: limit use of check pages Steven Rostedt
2008-05-22 17:38 ` Pekka Paalanen
2008-05-22 17:43 ` Steven Rostedt
2008-05-22 18:06 ` [PATCH] ftrace: fix check_pages disable set Steven Rostedt
2008-05-27 15:34 ` [PATCH 1/5] ftrace: limit use of check pages Thomas Gleixner
2008-05-22 4:22 ` [PATCH 2/5] ftrace: remove wakeup functions from sched_switch tracer Steven Rostedt
2008-05-22 9:46 ` Peter Zijlstra
2008-05-22 4:22 ` [PATCH 3/5] ftrace: move ftrace_special to trace.c Steven Rostedt
2008-05-22 4:22 ` [PATCH 4/5] ftrace: add function tracing to wake up tracing Steven Rostedt
2008-05-22 4:22 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080522042302.242307072@goodmis.org \
--to=rostedt@goodmis.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pq@iki.fi \
--cc=proski@gnu.org \
--cc=sandmann@redhat.com \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox