From: Dave Jones <davej@redhat.com>
To: Steve French <sfrench@us.ibm.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [CIFS] Fix reversed memset arguments.
Date: Thu, 22 May 2008 09:07:22 -0400 [thread overview]
Message-ID: <20080522130722.GA21163@redhat.com> (raw)
size is the 3rd argument.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6/fs/cifs/inode.c~ 2008-05-22 09:05:31.000000000 -0400
+++ linux-2.6/fs/cifs/inode.c 2008-05-22 09:05:58.000000000 -0400
@@ -172,7 +172,7 @@ static void fill_fake_finddataunix(FILE_
{
struct inode *pinode = NULL;
- memset(pfnd_dat, sizeof(FILE_UNIX_BASIC_INFO), 0);
+ memset(pfnd_dat, 0, sizeof(FILE_UNIX_BASIC_INFO));
/* __le64 pfnd_dat->EndOfFile = cpu_to_le64(0);
__le64 pfnd_dat->NumOfBytes = cpu_to_le64(0);
@@ -384,7 +384,7 @@ static int get_sfu_mode(struct inode *in
static void fill_fake_finddata(FILE_ALL_INFO *pfnd_dat,
struct super_block *sb)
{
- memset(pfnd_dat, sizeof(FILE_ALL_INFO), 0);
+ memset(pfnd_dat, 0, sizeof(FILE_ALL_INFO));
/* __le64 pfnd_dat->AllocationSize = cpu_to_le64(0);
__le64 pfnd_dat->EndOfFile = cpu_to_le64(0);
--
http://www.codemonkey.org.uk
next reply other threads:[~2008-05-22 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 13:07 Dave Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-05-22 14:22 [CIFS] Fix reversed memset arguments Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080522130722.GA21163@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox