* [CIFS] Fix reversed memset arguments.
@ 2008-05-22 13:07 Dave Jones
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jones @ 2008-05-22 13:07 UTC (permalink / raw)
To: Steve French; +Cc: Linux Kernel
size is the 3rd argument.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6/fs/cifs/inode.c~ 2008-05-22 09:05:31.000000000 -0400
+++ linux-2.6/fs/cifs/inode.c 2008-05-22 09:05:58.000000000 -0400
@@ -172,7 +172,7 @@ static void fill_fake_finddataunix(FILE_
{
struct inode *pinode = NULL;
- memset(pfnd_dat, sizeof(FILE_UNIX_BASIC_INFO), 0);
+ memset(pfnd_dat, 0, sizeof(FILE_UNIX_BASIC_INFO));
/* __le64 pfnd_dat->EndOfFile = cpu_to_le64(0);
__le64 pfnd_dat->NumOfBytes = cpu_to_le64(0);
@@ -384,7 +384,7 @@ static int get_sfu_mode(struct inode *in
static void fill_fake_finddata(FILE_ALL_INFO *pfnd_dat,
struct super_block *sb)
{
- memset(pfnd_dat, sizeof(FILE_ALL_INFO), 0);
+ memset(pfnd_dat, 0, sizeof(FILE_ALL_INFO));
/* __le64 pfnd_dat->AllocationSize = cpu_to_le64(0);
__le64 pfnd_dat->EndOfFile = cpu_to_le64(0);
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [CIFS] Fix reversed memset arguments.
@ 2008-05-22 14:22 Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2008-05-22 14:22 UTC (permalink / raw)
To: lkml, davej
Dave Jones <davej@redhat.com> wrote on 05/22/2008 08:07:22 AM:
Merged into cifs-2.6.git
Thanks for spotting this.
> size is the 3rd argument.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6/fs/cifs/inode.c~ 2008-05-22 09:05:31.000000000 -0400
> +++ linux-2.6/fs/cifs/inode.c 2008-05-22 09:05:58.000000000 -0400
> @@ -172,7 +172,7 @@ static void fill_fake_finddataunix(FILE_
> {
> struct inode *pinode = NULL;
>
> - memset(pfnd_dat, sizeof(FILE_UNIX_BASIC_INFO), 0);
> + memset(pfnd_dat, 0, sizeof(FILE_UNIX_BASIC_INFO));
>
> /* __le64 pfnd_dat->EndOfFile = cpu_to_le64(0);
> __le64 pfnd_dat->NumOfBytes = cpu_to_le64(0);
> @@ -384,7 +384,7 @@ static int get_sfu_mode(struct inode *in
> static void fill_fake_finddata(FILE_ALL_INFO *pfnd_dat,
> struct super_block *sb)
> {
> - memset(pfnd_dat, sizeof(FILE_ALL_INFO), 0);
> + memset(pfnd_dat, 0, sizeof(FILE_ALL_INFO));
>
> /* __le64 pfnd_dat->AllocationSize = cpu_to_le64(0);
> __le64 pfnd_dat->EndOfFile = cpu_to_le64(0);
> --
> http://www.codemonkey.org.uk
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-22 14:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-22 13:07 [CIFS] Fix reversed memset arguments Dave Jones
-- strict thread matches above, loose matches on Subject: below --
2008-05-22 14:22 Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox