From: Andi Kleen <andi@firstfloor.org>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@elte.hu>,
Arjan van de Ven <arjan@linux.intel.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] x86: don't destroy %rbp on kernel-mode faults
Date: Thu, 22 May 2008 15:07:26 +0200 [thread overview]
Message-ID: <20080522130726.GD31727@one.firstfloor.org> (raw)
In-Reply-To: <19f34abd0805220507w31e152ar5c9dd04f9774d0e1@mail.gmail.com>
> Hm, I am not sure exactly what a "real unwinder" would be. But I do
A dwarf2 unwinder that doesn't require pipe line stalls on many
CPUs on each function entry point for setting up a frame.
Instead of letting all code
maintain a frame at runtime the stack frames are described by
an external unwind table that is then walked by the unwinder.
The unwinder was in for a short time, but
Linus unfortunately removed it again because it took some time
to debug it in tree and he lost patience. I believe an updated
and stable version is available in the SUSE kernels.
> think it's fair to say that it is the assembly code in this case that
> is violating the binary interface, and not the stack tracer code.
There is a no binary interface for page faults (or other exceptions)
except that "all registers must be restored in the end". They certainly don't
follow the normal ABI.
Still the fix is good, just pointing out that you'll likely need
to change a lot more code to get the frame pointer fully supported
everywhere because it was all written under the explicit "no frame pointer"
assumption.
-Andi (who still prefers the unwinder)
prev parent reply other threads:[~2008-05-22 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 20:02 [RFC][PATCH] x86: don't destroy %rbp on kernel-mode faults Vegard Nossum
2008-05-19 20:22 ` Arjan van de Ven
2008-05-19 21:16 ` Andi Kleen
2008-05-22 12:07 ` Vegard Nossum
2008-05-22 13:07 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080522130726.GD31727@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox