From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756691AbYEVUSt (ORCPT ); Thu, 22 May 2008 16:18:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754122AbYEVUSi (ORCPT ); Thu, 22 May 2008 16:18:38 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.31.123]:41801 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753951AbYEVUSg (ORCPT ); Thu, 22 May 2008 16:18:36 -0400 Date: Thu, 22 May 2008 22:19:25 +0200 From: Pavel Machek To: Thomas Gleixner Cc: Ingo Molnar , kernel list , "H. Peter Anvin" , macro@ds2.pg.gda.pl Subject: Re: Automatical unification of i8259.c Message-ID: <20080522201925.GA14124@elf.ucw.cz> References: <20080520151528.GA1596@elf.ucw.cz> <20080520204750.GA31409@elte.hu> <20080521094402.GB12763@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > Make conversion of i8259 very mechanical -- i8259 was generated by > > diff -D, with too different parts left in i8259_32 and > > i8259_64.c. Only "by hand" changes were removal of #ifdef from middle > > of the comment (prevented compilation) and removal of one static to > > allow splitting into files. > > > > Of course, it will need some cleanups now, and those will follow. > > Applied. Thanks, Does that mean that followup patches are in, too? This is really too ugly to live alone ;-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html