From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756935AbYEVU36 (ORCPT ); Thu, 22 May 2008 16:29:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753236AbYEVU3t (ORCPT ); Thu, 22 May 2008 16:29:49 -0400 Received: from pasmtpa.tele.dk ([80.160.77.114]:49909 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752512AbYEVU3s (ORCPT ); Thu, 22 May 2008 16:29:48 -0400 Date: Thu, 22 May 2008 22:30:27 +0200 From: Sam Ravnborg To: Pavel Machek Cc: Thomas Gleixner , Ingo Molnar , kernel list , "H. Peter Anvin" , macro@ds2.pg.gda.pl Subject: Re: Automatical unification of i8259.c Message-ID: <20080522203027.GA24212@uranus.ravnborg.org> References: <20080520151528.GA1596@elf.ucw.cz> <20080520204750.GA31409@elte.hu> <20080521094402.GB12763@elf.ucw.cz> <20080522201925.GA14124@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080522201925.GA14124@elf.ucw.cz> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 22, 2008 at 10:19:25PM +0200, Pavel Machek wrote: > Hi! > > > > Make conversion of i8259 very mechanical -- i8259 was generated by > > > diff -D, with too different parts left in i8259_32 and > > > i8259_64.c. Only "by hand" changes were removal of #ifdef from middle > > > of the comment (prevented compilation) and removal of one static to > > > allow splitting into files. > > > > > > Of course, it will need some cleanups now, and those will follow. > > > > Applied. Thanks, > > Does that mean that followup patches are in, too? This is really too > ugly to live alone ;-). Hint: Look at: http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=shortlog;h=x86/i8259 Sam