From: Greg KH <greg@kroah.com>
To: Sean Hefty <sean.hefty@intel.com>
Cc: rolandd@cisco.com, hal.rosenstock@gmail.com,
general@lists.openfabrics.org, linux-kernel@vger.kernel.org
Subject: question about drivers/infiniband/core/cm.c's kobject usage
Date: Thu, 22 May 2008 13:34:03 -0700 [thread overview]
Message-ID: <20080522203403.GA27263@kroah.com> (raw)
Hi,
I was working on some changes to the driver core that is cleaning up the
struct class fields, when I ran accross the usage of cm.c and the
infiniband_cm class.
It looks like you are registering "raw" kobjects in this class, chaining
things off of it, as if they were devices.
If so, why not just use struct device in the first place? You are
creating a tree, which on modern distros, userspace will never see as
they are expecting everything to be showing up in /sys/devices/
Entries in /sys/class/*/* now are symlinks into the /sys/devices tree,
showing the representation of everything in one tree, not lots of little
trees all over the place.
So I was curious, was this done on purpose? If so, why? If not, any
objection to me switching it over to be using struct device properly?
thanks,
greg k-h
next reply other threads:[~2008-05-22 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 20:34 Greg KH [this message]
2008-05-22 21:47 ` question about drivers/infiniband/core/cm.c's kobject usage Sean Hefty
2008-05-22 21:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080522203403.GA27263@kroah.com \
--to=greg@kroah.com \
--cc=general@lists.openfabrics.org \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rolandd@cisco.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox