public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 3/8] debug printk infrastructure -compile fixes
@ 2008-05-22 21:16 Jason Baron
  2008-05-27 21:40 ` Andrew Morton
  0 siblings, 1 reply; 2+ messages in thread
From: Jason Baron @ 2008-05-22 21:16 UTC (permalink / raw)
  To: akpm, joe, greg, nick, randy.dunlap; +Cc: linux-kernel


Signed-off-by: Jason Baron <jbaron@redhat.com>
---
 net/netfilter/nf_conntrack_pptp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/netfilter/nf_conntrack_pptp.c b/net/netfilter/nf_conntrack_pptp.c
index 97e54b0..7fea304 100644
--- a/net/netfilter/nf_conntrack_pptp.c
+++ b/net/netfilter/nf_conntrack_pptp.c
@@ -65,7 +65,7 @@ void
 			     struct nf_conntrack_expect *exp) __read_mostly;
 EXPORT_SYMBOL_GPL(nf_nat_pptp_hook_expectfn);
 
-#ifdef DEBUG
+#if defined(DEBUG) || defined(CONFIG_DYNAMIC_PRINTK_DEBUG)
 /* PptpControlMessageType names */
 const char *const pptp_msg_name[] = {
 	"UNKNOWN_MESSAGE",
-- 
1.5.4.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/8] debug printk infrastructure -compile fixes
  2008-05-22 21:16 [PATCH 3/8] debug printk infrastructure -compile fixes Jason Baron
@ 2008-05-27 21:40 ` Andrew Morton
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2008-05-27 21:40 UTC (permalink / raw)
  To: Jason Baron; +Cc: joe, greg, nick, randy.dunlap, linux-kernel

On Thu, 22 May 2008 17:16:39 -0400
Jason Baron <jbaron@redhat.com> wrote:

> 
> Signed-off-by: Jason Baron <jbaron@redhat.com>
> ---
>  net/netfilter/nf_conntrack_pptp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/netfilter/nf_conntrack_pptp.c b/net/netfilter/nf_conntrack_pptp.c
> index 97e54b0..7fea304 100644
> --- a/net/netfilter/nf_conntrack_pptp.c
> +++ b/net/netfilter/nf_conntrack_pptp.c
> @@ -65,7 +65,7 @@ void
>  			     struct nf_conntrack_expect *exp) __read_mostly;
>  EXPORT_SYMBOL_GPL(nf_nat_pptp_hook_expectfn);
>  
> -#ifdef DEBUG
> +#if defined(DEBUG) || defined(CONFIG_DYNAMIC_PRINTK_DEBUG)
>  /* PptpControlMessageType names */
>  const char *const pptp_msg_name[] = {
>  	"UNKNOWN_MESSAGE",

Does this imply that the patch series will break bisectability?  If so,
this fix should be merged into whichever patch introduces the build
breakage.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-05-27 21:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-22 21:16 [PATCH 3/8] debug printk infrastructure -compile fixes Jason Baron
2008-05-27 21:40 ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox