public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>,
	Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
	Jiri Slaby <jirislaby@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Maciej W. Rozycki" <macro@linux-mips.org>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Andi Kleen <andi@firstfloor.org>
Subject: Re: [RFC] x86: merging nmi 32/64 to nmi.c v2
Date: Fri, 23 May 2008 07:33:14 +0400	[thread overview]
Message-ID: <20080523033314.GA6926@cvg> (raw)
In-Reply-To: <alpine.LFD.1.10.0805222320160.3295@apollo.tec.linutronix.de>

[Thomas Gleixner - Thu, May 22, 2008 at 11:37:34PM +0200]
| On Wed, 21 May 2008, Cyrill Gorcunov wrote:
| > 
| > Here is updated version (thanks Hiroshi) - I've moved these funcs
| > to traps_64.c and it's compiled just fine (so we are going closer
| > to merge someday even traps-32/64 ;)
| 
| Cyrill,
| 
| I really like that patch, but I'm a bit wary about the doit in one go
| approach. Its pretty hard to review that way and in case of breakage
| bisecting will just point to one large diff which is hard to decode.
| 
| Can you please try to make this a more fine grained patch series ?
| 
| Gradually add/modify the two files so they are identical at the
| end. There are a couple of obvious steps, e.g. the move of function to
| traps_*.c and adding the inline functions like get_timer_irqs().
| 
| Thanks,
| 	tglx
| 

Hi Thomas,

i think it was silly from my side to send such a *huge* patch at once,
but original idea was to get an overwiew of the change in general, that
is why I put changelog on top. So this patch (well RFC) was not to inclusion
but for review only ;) And even if you/Ingo have it applied to a tree it would
be totally undisectable anyway (as you pointed). So I will make quilt series
this weekend. Thanks a lot!

		- Cyrill -

      reply	other threads:[~2008-05-23  3:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 16:30 [RFC] x86: merging nmi 32/64 to nmi.c v2 Cyrill Gorcunov
2008-05-21 18:20 ` Hiroshi Shimamoto
2008-05-21 18:47   ` Cyrill Gorcunov
2008-05-21 19:21   ` Cyrill Gorcunov
2008-05-22 21:37     ` Thomas Gleixner
2008-05-23  3:33       ` Cyrill Gorcunov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080523033314.GA6926@cvg \
    --to=gorcunov@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=h-shimamoto@ct.jp.nec.com \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox