From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757406AbYEWJV0 (ORCPT ); Fri, 23 May 2008 05:21:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754578AbYEWJVR (ORCPT ); Fri, 23 May 2008 05:21:17 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:45196 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754461AbYEWJVQ (ORCPT ); Fri, 23 May 2008 05:21:16 -0400 Date: Fri, 23 May 2008 05:21:14 -0400 From: Christoph Hellwig To: Miklos Szeredi Cc: zippel@linux-m68k.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [patch 06/14] hfsplus: remove hfsplus_permission() Message-ID: <20080523092114.GD27119@infradead.org> References: <20080521171458.077908538@szeredi.hu> <20080521171549.964767446@szeredi.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 22, 2008 at 02:37:21PM +0200, Miklos Szeredi wrote: > That requires a quite bit more support from the VFS than just allowing > lookup to work on regular files without x bits. You'll have big > trouble with hard links for example: the VFS doesn't like non-leaf > dentries to be aliased. > > Besides hfsplus_permission() did not differentiate between execve on > the file and lookup on that file, allowing both. Which is obviously > wrong. Yes. Roman, if you care about details about the files as directories look in the reiser4 threads as it did something quite similar.