From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757004AbYEXEp3 (ORCPT ); Sat, 24 May 2008 00:45:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751630AbYEXEpV (ORCPT ); Sat, 24 May 2008 00:45:21 -0400 Received: from ns1.suse.de ([195.135.220.2]:57379 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036AbYEXEpU (ORCPT ); Sat, 24 May 2008 00:45:20 -0400 Date: Fri, 23 May 2008 21:43:54 -0700 From: Greg KH To: "Hans J. Koch" Cc: Uwe Kleine-K??nig , linux-kernel@vger.kernel.org, Jan Altenberg , Thomas Gleixner , Magnus Damm Subject: Re: [PATCH 1/1] UIO: Add a write() function to enable/disable interrupts Message-ID: <20080524044354.GA8129@suse.de> References: <20080522192252.GB3226@local> <20080522192637.GC3226@local> <20080523055527.GA28963@digi.com> <20080523104454.4e2af6ec@bluebox.local> <20080523091009.GA22821@digi.com> <20080523120308.7bec1e1c@bluebox.local> <20080523105604.GA23800@digi.com> <20080523135557.27fe4855@bluebox.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080523135557.27fe4855@bluebox.local> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 23, 2008 at 01:55:57PM +0200, Hans J. Koch wrote: > Sometimes it is necessary to enable/disable the interrupt of a UIO device > from the userspace part of the driver. With this patch, the UIO kernel driver > can implement an "irqcontrol()" function that does this. Userspace can write > an s32 value to /dev/uioX (usually 0 or 1 to turn the irq off or on). The > UIO core will then call the driver's irqcontrol function. Why not just a new sysfs file for the uio device, irq_enabled, or something like that? That way our main read/write path is left alone. thanks, greg k-h