Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration.

David Brownell
2008-05-22T03:38:53Z

On Friday 16 May 2008, Grant Likely wrote:
>
> This patch splits the allocation and registration portions of code out
> of spi_new_device() and creates three new functions; spi_alloc_device(),
> spi_register_device(), and spi_device_release().

I have no problem with the first two, but why the last?

If the devices are always allocated by spi_alloc_device() as
they should be -- probably through an intermediary -- the
only public function necessary for that cleanup should be
the existing spi_dev_put().

- Dave