Re: [PATCH] x86: use defconfig as last resort

Linus Torvalds
2008-05-25T01:31:47Z

On Sat, 24 May 2008, Sam Ravnborg wrote:
>
> When using "make oldconfig" with no .config
> present try the list from init/Kconfig DEFCONFIG_LIST
> before resorting to use one of the defconfigs.

Hmm. Why does placement matter here?

Also:

> +config DEFCONFIG_LIST
> + string
> + depends on X86_32
> + option defconfig_list
> + default "arch/x86/configs/i386_defconfig"
> +
> +config DEFCONFIG_LIST
> + string
> + depends on X86_64
> + option defconfig_list
> + default "arch/x86/configs/x86_64_defconfig"
> +

Wouldn't this be cleaner as just *one* entry, and then just have
different default statements, ie something like

config DEFCONFIG_LIST
string
option defconfig_list
default "arch/x86/configs/i386_defconfig" if X86_32
default "arch/x86/configs/x86_64_defconfig" if X86_64

instead?

Linus