The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	David Woodhouse <dwmw2@infradead.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
	Abhay Salunke <Abhay_Salunke@dell.com>,
	kay.sievers@vrfy.org, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option
Date: Sun, 25 May 2008 20:49:39 +0200	[thread overview]
Message-ID: <200805252049.39731.mb@bu3sch.de> (raw)
In-Reply-To: <orej7q1ewq.fsf@oliva.athome.lsd.ic.unicamp.br>

On Sunday 25 May 2008 19:17:57 Alexandre Oliva wrote:
> On May 25, 2008, Marcel Holtmann <marcel@holtmann.org> wrote:
> 
> > in the early days we had something like three drivers using the
> > request_firmware() and it was understood between the authors what the
> > filename was meant for.
> 
> You're contradicting yourself.  Is it a filename, or is it not?
> Earlier, you said it wasn't, it was just a name that userspace was
> supposed to map to a filename.  Now, you're saying it is a filename.
> 
> Clearly (to me) your wish to prohibit '/'s in the firmware name has to
> do with an attempt to force a distiction, to make the firmware a
> filename rather than a pathname.  But, as you said yourself, the
> mapping from firmware name is supposed to be entirely handled in
> userland, therefore it doesn't even begin to make sense to distinguish
> between filenames and pathnames.  You'd have to make assumptions that
> (i) the firmware name names files (with built-in firmware, it
> doesn't), and, if it is about filenames, (ii) what the pathname
> separator character is.  Should '\\' be ruled out as well, because
> someone might want /lib/firmware to be in a FAT filesystem?
> 
> nWouldn't it be better to leave the resolution of firmware names to
> content *entirely* up to userland?  Say, if userland wants to
> implement something very similar to the key-to-data map in-kernel
> built-in firmware, this would work just fine, without any artificial
> constraints?

One additional thing is to make sure the usability of the whole stuff
is not reduded. Currently I can do:

modprobe b43 fwpostfix=-open
# work with opensource firmware in b43-open/
rmmod b43
modprobe b43
# work with standard firmware in b43/

So it is really simple to switch between different flavours of firmware.
It is _not_ acceptable to change an udev configuration file all the time,
if you want to use another firmware. One needs to frequently switch
between firmware versions when developing firmware code.

-- 
Greetings Michael.

  parent reply	other threads:[~2008-05-25 18:50 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-23 13:44 [PATCH 1/3] firmware: allow firmware files to be built into kernel image David Woodhouse
2008-05-23 13:46 ` [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option David Woodhouse
2008-05-23 13:50   ` [PATCH 2/3] firmware: convert korg1212 driver to use firmware loader exclusively David Woodhouse
2008-05-23 14:56     ` Takashi Iwai
2008-05-23 14:59       ` David Woodhouse
2008-05-23 16:41   ` [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option Sam Ravnborg
2008-05-23 17:13     ` David Woodhouse
2008-05-23 18:07     ` David Woodhouse
2008-05-23 18:11       ` Sam Ravnborg
2008-05-24 14:46     ` David Woodhouse
2008-05-24 15:22       ` Sam Ravnborg
2008-05-24 15:25         ` David Woodhouse
2008-05-24 15:34           ` David Woodhouse
2008-05-24 18:18             ` Marcel Holtmann
2008-05-24 19:23               ` David Woodhouse
2008-05-24 19:31                 ` Marcel Holtmann
2008-05-25  9:30               ` Johannes Berg
2008-05-25  9:49                 ` Michael Buesch
2008-05-25 11:54                   ` Marcel Holtmann
2008-05-25 12:14                     ` Michael Buesch
2008-05-25 13:16                       ` Alan Cox
2008-05-25 13:46                         ` David Woodhouse
2008-05-25 18:07                           ` Marcel Holtmann
2008-05-25 11:49                 ` Marcel Holtmann
2008-05-25 11:59                   ` Johannes Berg
2008-05-25 13:12                     ` Marcel Holtmann
2008-05-25 13:40                       ` Johannes Berg
2008-05-25 18:12                         ` Marcel Holtmann
2008-05-25 18:18                           ` Michael Buesch
2008-05-25 18:28                             ` Marcel Holtmann
2008-05-26  8:57                           ` Johannes Berg
2008-05-25 12:05                   ` Michael Buesch
2008-05-25 13:19                     ` Marcel Holtmann
2008-05-25 13:45                       ` Michael Buesch
2008-05-25 18:15                         ` Marcel Holtmann
2008-05-25 18:27                           ` Michael Buesch
2008-05-25 18:34                             ` Marcel Holtmann
2008-05-25 14:13                       ` Johannes Berg
2008-05-25 14:18                         ` David Woodhouse
2008-05-25 14:22                           ` Johannes Berg
2008-05-25 18:23                         ` Marcel Holtmann
2008-05-25 18:39                           ` Michael Buesch
2008-05-25 18:46                             ` Marcel Holtmann
2008-05-25 18:53                               ` Michael Buesch
2008-05-25 19:03                                 ` Marcel Holtmann
2008-05-25 19:21                                   ` Michael Buesch
2008-05-26  8:52                               ` Johannes Berg
2008-05-25 17:17                   ` Alexandre Oliva
2008-05-25 18:49                     ` Marcel Holtmann
2008-05-25 19:53                       ` Alan Cox
2008-05-26  3:30                       ` Alexandre Oliva
2008-05-25 18:49                     ` Michael Buesch [this message]
2008-05-25 19:01                       ` Marcel Holtmann
2008-05-25 19:09                         ` Michael Buesch
2008-05-26  3:13                       ` Alexandre Oliva
2008-05-26 12:53                         ` Michael Buesch
2008-05-26 13:08                           ` Johannes Berg
2008-05-26 17:09                           ` Alexandre Oliva
2008-05-26 17:11                             ` Michael Buesch
2008-05-23 14:53 ` [PATCH 1/3] firmware: allow firmware files to be built into kernel image Takashi Iwai
2008-05-23 14:58   ` David Woodhouse
2008-05-23 15:19     ` Takashi Iwai
2008-05-23 15:25       ` David Woodhouse
2008-05-23 15:33     ` Alan Cox
2008-05-23 17:21       ` David Woodhouse
2008-05-23 19:14       ` David Woodhouse
2008-05-23 19:42         ` David Woodhouse
2008-05-23 20:31           ` Alan Cox
2008-05-23 21:04             ` David Woodhouse
2008-05-23 23:28             ` David Woodhouse
2008-05-23 14:56 ` Alan Cox
2008-05-23 15:11   ` David Woodhouse
2008-05-23 15:00 ` Clemens Ladisch
2008-05-23 15:20   ` David Woodhouse
2008-05-23 15:32   ` Alan Cox
2008-05-23 16:21 ` Sam Ravnborg
2008-05-23 16:37   ` David Dillow
2008-05-23 16:38   ` Lennart Sorensen
2008-05-23 16:44     ` Sam Ravnborg
2008-05-23 16:53       ` Rene Herman
2008-05-23 17:06         ` David Woodhouse
2008-05-23 17:49   ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805252049.39731.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=Abhay_Salunke@dell.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=aoliva@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=sam@ravnborg.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox