From: Andrew Morton <akpm@linux-foundation.org>
To: Jason Baron <jbaron@redhat.com>
Cc: joe@perches.com, greg@kroah.com, nick@nick-andrew.net,
randy.dunlap@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] debug printk infrastructure -compile fixes
Date: Tue, 27 May 2008 14:40:23 -0700 [thread overview]
Message-ID: <20080527144023.bf47e3e6.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080522211639.GD28070@redhat.com>
On Thu, 22 May 2008 17:16:39 -0400
Jason Baron <jbaron@redhat.com> wrote:
>
> Signed-off-by: Jason Baron <jbaron@redhat.com>
> ---
> net/netfilter/nf_conntrack_pptp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/netfilter/nf_conntrack_pptp.c b/net/netfilter/nf_conntrack_pptp.c
> index 97e54b0..7fea304 100644
> --- a/net/netfilter/nf_conntrack_pptp.c
> +++ b/net/netfilter/nf_conntrack_pptp.c
> @@ -65,7 +65,7 @@ void
> struct nf_conntrack_expect *exp) __read_mostly;
> EXPORT_SYMBOL_GPL(nf_nat_pptp_hook_expectfn);
>
> -#ifdef DEBUG
> +#if defined(DEBUG) || defined(CONFIG_DYNAMIC_PRINTK_DEBUG)
> /* PptpControlMessageType names */
> const char *const pptp_msg_name[] = {
> "UNKNOWN_MESSAGE",
Does this imply that the patch series will break bisectability? If so,
this fix should be merged into whichever patch introduces the build
breakage.
prev parent reply other threads:[~2008-05-27 21:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 21:16 [PATCH 3/8] debug printk infrastructure -compile fixes Jason Baron
2008-05-27 21:40 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080527144023.bf47e3e6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=jbaron@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@nick-andrew.net \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox