public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Qinghuang Feng <s3c24xx@gmail.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]scsi: check the return value of device_create_file() in powertec.c
Date: Wed, 28 May 2008 15:42:29 +0100	[thread overview]
Message-ID: <20080528144229.GG15470@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200805252118.25798.s3c24xx@gmail.com>

On Sun, May 25, 2008 at 09:18:25PM +0800, Qinghuang Feng wrote:
> This patch adds code to check the return value of device_create_file() called from powertecscsi_probe() in powertec.c 

I'd prefer not to kill the driver if device_create_file fails.  Just
arrange to print a warning instead (and remember not to unregister
the file if it wasn't created.)

      reply	other threads:[~2008-05-28 14:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-25 13:18 [PATCH]scsi: check the return value of device_create_file() in powertec.c Qinghuang Feng
2008-05-28 14:42 ` Russell King - ARM Linux [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080528144229.GG15470@flint.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s3c24xx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox