From: Paul Jackson <pj@sgi.com>
To: miaox@cn.fujitsu.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
menage@google.com
Subject: Re: [RFC] [PATCH] cpusets: update tasks' cpus_allowed and mems_allowed after CPU/NODE offline/online
Date: Wed, 28 May 2008 22:33:53 -0500 [thread overview]
Message-ID: <20080528223353.61affb22.pj@sgi.com> (raw)
In-Reply-To: <483E1D77.30400@cn.fujitsu.com>
Miao wrote:
> Though the patch is a little big, most of the change is just code restruction.
This looks like a nice bug fix - thanks!
Allow me to ask a question, but I hope you will be happy to answer yes
or no, either way, as you see it.
The question is:
Would it be easy to split this patch into two pieces, where:
1) the first piece contains the restructuring (but is still buggy), and
2) the second piece has just the bug fix?
If that would be easy, that might make a nice way to present this fix.
If that would not be so easy, that's ok ... I can still review easily
enough. I'll just have to drink an extra cup of coffee first, to make
my mind a little more alert <grin>.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214
next prev parent reply other threads:[~2008-05-29 3:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 3:05 [RFC] [PATCH] cpusets: update tasks' cpus_allowed and mems_allowed after CPU/NODE offline/online Miao Xie
2008-05-29 3:33 ` Paul Jackson [this message]
2008-05-29 3:41 ` Miao Xie
2008-05-29 3:43 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080528223353.61affb22.pj@sgi.com \
--to=pj@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox